Skip to content

MUL311: Remove duplicate operations from statistics-mtg2 #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tweska wants to merge 2 commits into
base: develop
Choose a base branch
from
+0 −340
Open

MUL311: Remove duplicate operations from statistics-mtg2 #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e6a3c9
MUL-311: Remove `de-accumulate` operation
tweska Nov 7, 2025
30a1399
MUL-311: Remove `flux-average` and `fixed-window-flux-average` operat…
tweska Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/multio/action/statistics-mtg2/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,9 @@ list( APPEND _statistics_sources
operations/Average.h
operations/Difference.h
operations/InverseDifference.h
operations/FluxAverage.h
operations/Instant.h
operations/Minimum.h
operations/Maximum.h
operations/DeAccumulate.h
operations/FixedWindowFluxAverage.h
operations/StdDev.h
mappings/StatisticsParamMapping.cc
mappings/StatisticsParamMapping.h
Expand Down
25 changes: 0 additions & 25 deletions src/multio/action/statistics-mtg2/Operations.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,11 @@
#include "multio/action/statistics-mtg2/operations/Average.h"
#include "multio/action/statistics-mtg2/operations/Difference.h"
#include "multio/action/statistics-mtg2/operations/InverseDifference.h"
#include "multio/action/statistics-mtg2/operations/FluxAverage.h"
#include "multio/action/statistics-mtg2/operations/Instant.h"
#include "multio/action/statistics-mtg2/operations/Maximum.h"
#include "multio/action/statistics-mtg2/operations/Minimum.h"
#include "multio/action/statistics-mtg2/operations/StdDev.h"

#include "multio/action/statistics-mtg2/operations/DeAccumulate.h"
#include "multio/action/statistics-mtg2/operations/FixedWindowFluxAverage.h"

namespace multio::action::statistics_mtg2 {

template <typename Precision>
Expand All @@ -49,9 +45,6 @@ std::unique_ptr<Operation> make_operation(const std::string& opname, long sz, st
if (opname == "inverse-difference") {
return std::make_unique<InverseDifference<Precision>>(opname, sz, win, cfg);
}
if (opname == "flux-average") {
return std::make_unique<FluxAverage<Precision>>(opname, sz, win, cfg);
}
if (opname == "minimum") {
return std::make_unique<Minimum<Precision>>(opname, sz, win, cfg);
}
Expand All @@ -61,12 +54,6 @@ std::unique_ptr<Operation> make_operation(const std::string& opname, long sz, st
if (opname == "accumulate") {
return std::make_unique<Accumulate<Precision>>(opname, sz, win, cfg);
}
if (opname == "de-accumulate") {
return std::make_unique<DeAccumulate<Precision>>(opname, sz, win, cfg);
}
if (opname == "fixed-window-flux-average") {
return std::make_unique<FixedWindowFluxAverage<Precision>>(opname, sz, win, cfg);
}
if (opname == "stddev") {
return std::make_unique<StdDev<Precision>>(opname, sz, win, cfg);
}
Expand Down Expand Up @@ -100,10 +87,6 @@ std::unique_ptr<Operation> load_operation(const std::string& opname, std::shared
found = true;
ret = std::make_unique<InverseDifference<Precision>>(opname, win, IOmanager, opt);
}
if (opname == "flux-average") {
found = true;
ret = std::make_unique<FluxAverage<Precision>>(opname, win, IOmanager, opt);
}
if (opname == "minimum") {
found = true;
ret = std::make_unique<Minimum<Precision>>(opname, win, IOmanager, opt);
Expand All @@ -116,14 +99,6 @@ std::unique_ptr<Operation> load_operation(const std::string& opname, std::shared
found = true;
ret = std::make_unique<Accumulate<Precision>>(opname, win, IOmanager, opt);
}
if (opname == "de-accumulate") {
found = true;
ret = std::make_unique<DeAccumulate<Precision>>(opname, win, IOmanager, opt);
}
if (opname == "fixed-window-flux-average") {
found = true;
ret = std::make_unique<FixedWindowFluxAverage<Precision>>(opname, win, IOmanager, opt);
}
if (opname == "stddev") {
throw eckit::NotImplemented(Here());
}
Expand Down
60 changes: 0 additions & 60 deletions src/multio/action/statistics-mtg2/operations/DeAccumulate.h
View file
Open in desktop

This file was deleted.

62 changes: 0 additions & 62 deletions src/multio/action/statistics-mtg2/operations/FixedWindowFluxAverage.h
View file
Open in desktop

This file was deleted.

57 changes: 0 additions & 57 deletions src/multio/action/statistics-mtg2/operations/FluxAverage.h
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions tests/multio/action/statistics-mtg2/operations/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,27 +43,6 @@ ecbuild_add_test(
LIBS multio-action-debug-sink multio-action-statistics-mtg2
)

ecbuild_add_test(
TARGET ${PREFIX}_deaccumulate
SOURCES DeAccumulate.cc
NO_AS_NEEDED
LIBS multio-action-debug-sink multio-action-statistics-mtg2
)

ecbuild_add_test(
TARGET ${PREFIX}_flux_average
SOURCES FluxAverage.cc
NO_AS_NEEDED
LIBS multio-action-debug-sink multio-action-statistics-mtg2
)

ecbuild_add_test(
TARGET ${PREFIX}_fixed_window_flux_average
SOURCES FixedWindowFluxAverage.cc
NO_AS_NEEDED
LIBS multio-action-debug-sink multio-action-statistics-mtg2
)

ecbuild_add_test(
TARGET ${PREFIX}_instant
SOURCES Instant.cc
Expand Down
36 changes: 0 additions & 36 deletions tests/multio/action/statistics-mtg2/operations/DeAccumulate.cc
View file
Open in desktop

This file was deleted.

38 changes: 0 additions & 38 deletions tests/multio/action/statistics-mtg2/operations/FixedWindowFluxAverage.cc
View file
Open in desktop

This file was deleted.

Loading
Loading