fix(mouse): restore log text selection + clipboard + Alt+m runtime toggle (#45) * docs(mouse): plan to restore log text selection / copy Documents the regression introduced by the v1 mouse-support feature: crossterm's EnableMouseCapture emits ?1003 (any-motion tracking), which breaks Shift+drag native text selection on every modern terminal — even though Moved events are dropped at the event boundary and ?1003 buys zero functional value. Plan covers a three-part fix: - drop ?1003 from the capture sequence (hand-write 1000/1002/1006) - Alt+m runtime toggle with a [mouse] / [mouse-off] status indicator - right-click on a log row copies the line via a new Clipboard service Includes a ten-task breakdown across four waves with a file-overlap matrix; all wave-peers are parallel-safe. Co-Authored-By: Claude Opus 4.7 (1M context) * merge: 01-drop-1003-and-runtime-toggle from worktree * merge: 02-clipboard-service from worktree * merge: 03-messages-and-state from worktree * merge: 04-right-click-copy from worktree * merge: 05-alt-m-toggle-binding from worktree * merge: 06-update-handler-arms from worktree * merge: 07-runner-side-effect from worktree * merge: 08-status-indicator from worktree * merge: 09-non-core-docs from worktree * merge: 10-architecture-doc from worktree * docs(mouse): IDE-terminal limitations + bug-fix review and follow-up plan - docs/MOUSE.md: add "IDE built-in terminals" section with 8-IDE compatibility matrix (Zed, VS Code, Cursor, Windsurf, JetBrains, Fleet, Neovim, Helix) and per-IDE workarounds. - workflow/plans/bugs/log-text-selection-broken/: orchestrator-applied Completion Summaries on all 10 task files + status table updates in TASKS.md. - workflow/reviews/bugs/log-text-selection-broken/: 6-agent code review verdict (NEEDS WORK) with consolidated REVIEW.md and prioritized ACTION_ITEMS.md. - workflow/plans/bugs/log-text-selection-followup/: 9-task follow-up plan addressing 4 blockers + 8 should-fix + 6 of 10 debt items from the review; 4 deferred items documented under Future Considerations. Co-Authored-By: Claude Opus 4.7 (1M context) * 04-test-and-quality-polish: vacuous assertion, EXCEPTION annotation, magic number, resolve_entry_text tests, Unicode contract - Rewrite vacuous second assertion in test_status_info_renders_mouse_off_badge to directly check absence of "[mouse]" (on-state badge) rather than a tautology - Conform EXCEPTION annotation in handler/mouse/mod.rs to required (TEA) style with cross-references to both CODE_STANDARDS.md and REVIEW_FOCUS.md - Extract magic number 60 into COPY_TOAST_PREVIEW_CHARS constant in update.rs; reference from call site and test bound - Add three focused unit tests for resolve_entry_text (no session, missing id, matching entry); expose function as pub(crate) and re-export for tests - Add Unicode-scalar-vs-grapheme contract doc-comment to truncate_with_ellipsis Co-Authored-By: Claude Sonnet 4.6 * 05-keys-and-suppression: Shift+Alt+m support + dialog-aware suppression + new tests - Widen Alt+m match to CharAlt('m' | 'M') to accept Shift+Alt+m - Refine NewSessionDialog/Startup suppression to check focused_pane: TargetSelector (device picker) no longer suppresses Alt+m; LaunchContext (text fields) still suppresses; sub-modals always suppress - Add 4 new tests: shift_alt_m toggle, settings-editing suppression, NewSessionDialog TargetSelector fires, NewSessionDialog LaunchContext suppresses Co-Authored-By: Claude Sonnet 4.6 * merge: 01-null-clipboard-service from worktree - Add NullClipboard service (returns Err) - cfg-gate MemoryClipboard to #[cfg(test)] - Substitute NullClipboard for MemoryClipboard in three runner.rs fallback sites (necessary scope expansion: gating MemoryClipboard broke compilation) Co-Authored-By: Claude Opus 4.7 (1M context) * merge: 02-terminal-doc-correction from worktree Fix set_mouse_capture disable-path doc-comment to accurately describe that disable errors are logged at warn but cannot be propagated. Co-Authored-By: Claude Opus 4.7 (1M context) * merge: 03-architecture-doc-fix from worktree Remove (?1003 DECSET) parenthetical from SetMouseCapture description in docs/ARCHITECTURE.md per doc content boundaries. Co-Authored-By: Claude Opus 4.7 (1M context) * merge: 07-state-visibility from worktree Fix misleading pending_runner_actions doc-comment (Option B kept pub for cross-crate test access; comment now accurately documents the Engine::drain_runner_actions access contract). Co-Authored-By: Claude Opus 4.7 (1M context) * merge: 06-plan-md-hyperlink from worktree Convert prose backtick path reference in mouse-support/PLAN.md to a proper markdown hyperlink. Co-Authored-By: Claude Opus 4.7 (1M context) * 08-runner-correctness: try_send fallback, startup toast, exhaustive match - try_send fallback: when the message channel is saturated after set_mouse_capture succeeds, apply state.mouse_capture_active = target and push a ToastLevel::Warn toast directly so the TEA model never lies about the terminal's mouse-capture state. - Startup toast: both run_with_project and run_with_project_and_dap now capture clipboard_unavailable_reason and push a ToastLevel::Warn toast before the first frame so users see the degraded state on launch. - Exhaustive match: replace the `_ => warn!(...)` catch-all in handle_runner_actions with an explicit list of all non-runner UpdateAction variants, forcing the compiler to require a decision when new variants are added. - New tests: test_mouse_capture_changed_channel_full_applies_state_directly and test_null_clipboard_returns_err_and_runner_pushes_toast. Co-Authored-By: Claude Sonnet 4.6 * 09-manual-test-matrix: remove leaked dev-time config files and guard .gitignore Delete crates/fdemon-tui/.fdemon/config.toml and crates/fdemon-tui/.gitignore that were accidentally committed during Task 04 testing. Add root .gitignore rules for **/.fdemon/config.toml, **/.fdemon/settings.local.toml, and **/.fdemon/launch.toml to prevent re-introduction of these per-user auto-generated files. * docs(bug-followup): completion summaries + TASKS.md status + BUG.md check-offs Aggregates the workflow/plans/ updates from the 9-task log-text-selection follow-up orchestration: - TASKS.md: mark all 9 tasks Done with orchestration notes (Task 01 scope expansion, Task 04 leaked-artifact cleanup, Task 05 stale comment, Task 07 Option B rationale, Task 09 partial completion) - 01-09 task files: append per-task Completion Summary blocks - Parent BUG.md: programmatic success-criteria check-offs and Human-Verification Remaining section Co-Authored-By: Claude Opus 4.7 (1M context) * docs(plans): add installation-methods feature plan (WIP, unrelated to current branch) Drops in the WIP plan for the installation-methods feature so it travels with the working tree. Not in scope for the log-text-selection follow-up on this branch — will be picked up as future work. Related issues: - https://github.com/edTheGuy00/fdemon/issues/41 - https://github.com/edTheGuy00/fdemon/issues/40 Co-Authored-By: Claude Opus 4.7 (1M context) * website(mouse): port all MOUSE.md sections to mouse.rs Adds six missing sections (Selecting and Copying Log Text, Coordinate-Free Routing, IDE built-in terminals caveat, Pointer shape (OSC 22) caveat, Runtime Toggle, Future Work) and refines existing sections (Compact NewSessionDialog, Modal Precedence z-index table, Phase 5 ConfirmDialog/ TagFilter/LinkHighlight/NewSessionDialog/Settings detail) to match the canonical MOUSE.md exactly. Co-Authored-By: Claude Sonnet 4.6 * fix(ci): redact app version from normal-mode snapshot tests The four `snapshot_normal_mode_*` tests embed `Flutter Demon v0.5.0` in their stored snapshots, so any version bump on `main` (e.g. the recent `0.5.0 → 0.5.1` release commit) causes the PR merge-commit to render a different version, breaking the snapshots in CI even though the rendered layout is otherwise unchanged. Add an `insta::with_settings!` filter that rewrites `Flutter Demon v\d+\.\d+\.\d+` to a literal `vX.Y.Z` placeholder, and re-stamp the four .snap files with the placeholder. Future version bumps no longer touch these snapshots. Co-Authored-By: Claude Opus 4.7 (1M context) * chore: widen .claude/ gitignore to cover all session state Previously only .claude/worktrees/ was ignored, so per-session artifacts like scheduled_tasks.lock, settings.local.json, and .DS_Store kept showing up as untracked. Ignore the entire .claude/ directory instead. Co-Authored-By: Claude Opus 4.7 (1M context) * docs(mouse): address PR #45 Copilot review comments Six small fixes for stale comments / doc drift surfaced by the Copilot PR review. No runtime behavior changes; one test strengthened. - input_key.rs: drop false claim that `CharAlt` canonicalises the meta-prefix `Esc`+key encoding (event.rs only maps the `ALT` modifier). - handler/keys.rs: rewrite the Alt+m suppression comment to match the pane-aware logic — only `LaunchContext` (not the whole dialog) is suppressed, and `TargetSelector` still toggles capture. - ARCHITECTURE.md: list `NullClipboard` in the public-API entry and mark `MemoryClipboard` as `#[cfg(test)]`-only. - MOUSE.md: drop the "one-second" duration claim (toasts live for `TOAST_TTL_SECS = 5`). - terminal.rs (`set_mouse_capture`): remove the stale inline comment describing a replication-of-disable-logic path that was never taken; the function-level doc already documents the actual behavior. - log_view/tests.rs (compact-mode badge test): also assert that `[mouse-off]` is absent — `[mouse-off]` does not contain the substring `[mouse]`, so the prior single assertion would not catch a wrong-badge regression under width pressure. Co-Authored-By: Claude Opus 4.7 (1M context) --------- Co-authored-by: Claude Opus 4.7 (1M context)

curl error on linux #41

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions