Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create acceptance tests #3

Open
treyhunner opened this issue Aug 29, 2012 · 6 comments
Open

Create acceptance tests #3

treyhunner opened this issue Aug 29, 2012 · 6 comments

Comments

@treyhunner
Copy link
Member

Create tests that combine multiple properties in particular ways.

These tests should be for scenarios that are:

  1. Common (many projects may use the set of properties tested)
  2. Potentially problematic (tests for clashes between particular properties)

Some planned acceptance tests:

  1. Visual Studio Setup:

    charset = utf-8-bom
    insert_final_newline = false
    end_of_line = crlf
    
  2. Linux Setup:

    charset = utf-8
    insert_final_newline = true
    end_of_line = lf
    
  3. Sublime Setup:

    charset = utf-8
    insert_final_newline = false
    end_of_line = lf
    
@xuhdev
Copy link
Member

xuhdev commented Sep 9, 2012

I don't think end_of_line is fixed for sublime on every OS...

I think maybe your Common means something like BSD style, ANSI style, etc.?

@xuhdev
Copy link
Member

xuhdev commented Sep 9, 2012

But not restricted to C coding styles.

@xuhdev
Copy link
Member

xuhdev commented Sep 9, 2012

@treyhunner
Copy link
Member Author

I haven't tried Sublime on Windows so I don't know whether it uses CRLF. We could add that as a use case also. The names I'm giving these are primarily just for the purpose of labeling common use cases. By common I don't necessarily mean named coding styles (BSD, ANSI, etc.) but coding styles that are frequently used by some large sample of users or projects.

@xuhdev
Copy link
Member

xuhdev commented Sep 13, 2012

Yes, I agree that we should deal with common styles more. But I think these named styles are in fact commonly used. In fact, our C core is using BSD style (or very similar to).

But I am not sure about the named styles of other languages... For example Python, I think the style is quite unified, but I am not sure.

@xuhdev
Copy link
Member

xuhdev commented Sep 19, 2012

I've added a Linux coding style at the template directory: b68005f

If you think the location is inappropriate, we can change it then. But I think naming it template is good, because people can find the template they want there, for common coding styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants