From d491f326db5e2b5b6fe0cf5d485aba2b0e75edeb Mon Sep 17 00:00:00 2001 From: Grigory Date: Wed, 27 Nov 2024 11:01:34 +0500 Subject: [PATCH 1/5] ci(workflows): update actions --- .github/workflows/release.yml | 6 +++--- .github/workflows/test.yml | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 0d87184..3b9d1d6 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -42,11 +42,11 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Setup Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v4 with: - node-version: 16 + node-version: lts/* - name: Install env: CI: true diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 80776a0..a0173f5 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -26,9 +26,9 @@ jobs: - name: Preserve line endings run: git config --global core.autocrlf false - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Setup Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} - name: Start xvfb From 0294aa58cb7fb4e53ca9300ecec611fd3bdb4b3e Mon Sep 17 00:00:00 2001 From: Grigory Date: Wed, 27 Nov 2024 11:25:37 +0500 Subject: [PATCH 2/5] ci(workflows/test): cache vscode installation --- .github/workflows/test.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a0173f5..416428a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -27,6 +27,12 @@ jobs: run: git config --global core.autocrlf false - name: Checkout uses: actions/checkout@v4 + - name: Cache vscode installation + uses: actions/cache@v4 + with: + path: .vscode-test + key: vscode-installation-${{ matrix.os }}-${{ github.sha }} + restore-keys: vscode-installation-${{ matrix.os }}- - name: Setup Node uses: actions/setup-node@v4 with: From c5da8299792ffdcb04997da1b26507530f316272 Mon Sep 17 00:00:00 2001 From: Grigory Date: Thu, 30 Jan 2025 13:06:34 +0500 Subject: [PATCH 3/5] remove redunant env vars https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables --- .github/workflows/release.yml | 2 -- .github/workflows/test.yml | 1 - 2 files changed, 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 3b9d1d6..56c26bc 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -48,8 +48,6 @@ jobs: with: node-version: lts/* - name: Install - env: - CI: true run: npm ci - name: Create Changelog run: | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 416428a..0f44656 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -47,5 +47,4 @@ jobs: npm ci npm test env: - CI: true DISPLAY: ":99.0" From eb236ced97ae4b790c3c9375a63259fd69a4df3a Mon Sep 17 00:00:00 2001 From: Grigory Date: Thu, 30 Jan 2025 18:45:05 +0500 Subject: [PATCH 4/5] chore(pr template): `npm run compile` -> `npm run build` --- .github/PULL_REQUEST_TEMPLATE.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index acb1a6f..f11cefa 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,6 +2,5 @@ Please fill in this template. - [ ] Use a meaningful title for the pull request. - [ ] Use meaningful commit messages. -- [ ] Run `tsc` w/o errors (same as `npm run compile`). +- [ ] Run `tsc` w/o errors (same as `npm run build`). - [ ] Run `npm run lint` w/o errors. - From 2c9179097b8081a4d885d034b0d7ae6c5fc41fe5 Mon Sep 17 00:00:00 2001 From: Grigory Date: Thu, 30 Jan 2025 20:29:01 +0500 Subject: [PATCH 5/5] Revert "ci(workflows/test): cache vscode installation" This reverts commit 0294aa58cb7fb4e53ca9300ecec611fd3bdb4b3e. Don't remember why I was thinking that this significtly reduces workflow execution time, but now I cheked it and it doesn't. --- .github/workflows/test.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 0f44656..c7367b3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -27,12 +27,6 @@ jobs: run: git config --global core.autocrlf false - name: Checkout uses: actions/checkout@v4 - - name: Cache vscode installation - uses: actions/cache@v4 - with: - path: .vscode-test - key: vscode-installation-${{ matrix.os }}-${{ github.sha }} - restore-keys: vscode-installation-${{ matrix.os }}- - name: Setup Node uses: actions/setup-node@v4 with: