From 38873d27c515eda1b07b28b0375d092ffb02ff0c Mon Sep 17 00:00:00 2001 From: Hong Xu Date: Thu, 6 Feb 2025 12:54:50 -0800 Subject: [PATCH 1/3] Remove node 18 Support Seems like the latest VSCode doesn't support Node 18 any more. --- .github/workflows/test.yml | 2 +- package-lock.json | 20 +++++++++++--------- package.json | 2 +- renovate.json | 7 +++++++ 4 files changed, 20 insertions(+), 11 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b45ba24..0653891 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -16,7 +16,7 @@ jobs: strategy: matrix: - node: [18, 20, 22] + node: [20, 22] os: - ubuntu-latest - windows-latest diff --git a/package-lock.json b/package-lock.json index b1c2071..714c487 100644 --- a/package-lock.json +++ b/package-lock.json @@ -13,7 +13,7 @@ }, "devDependencies": { "@types/mocha": "^10.0.10", - "@types/node": "^18.19.74", + "@types/node": "^20.14.8", "@types/vscode": "^1.82.0", "@typescript-eslint/eslint-plugin": "^8.22.0", "@typescript-eslint/parser": "^8.22.0", @@ -502,12 +502,13 @@ "dev": true }, "node_modules/@types/node": { - "version": "18.19.74", - "resolved": "https://registry.npmjs.org/@types/node/-/node-18.19.74.tgz", - "integrity": "sha512-HMwEkkifei3L605gFdV+/UwtpxP6JSzM+xFk2Ia6DNFSwSVBRh9qp5Tgf4lNFOMfPVuU0WnkcWpXZpgn5ufO4A==", + "version": "20.17.17", + "resolved": "https://registry.npmjs.org/@types/node/-/node-20.17.17.tgz", + "integrity": "sha512-/WndGO4kIfMicEQLTi/mDANUu/iVUhT7KboZPdEqqHQ4aTS+3qT3U5gIqWDFV+XouorjfgGqvKILJeHhuQgFYg==", "dev": true, + "license": "MIT", "dependencies": { - "undici-types": "~5.26.4" + "undici-types": "~6.19.2" } }, "node_modules/@types/vscode": { @@ -5715,10 +5716,11 @@ } }, "node_modules/undici-types": { - "version": "5.26.5", - "resolved": "https://registry.npmjs.org/undici-types/-/undici-types-5.26.5.tgz", - "integrity": "sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA==", - "dev": true + "version": "6.19.8", + "resolved": "https://registry.npmjs.org/undici-types/-/undici-types-6.19.8.tgz", + "integrity": "sha512-ve2KP6f/JnbPBFyobGHuerC9g1FYGn/F8n1LWTwNxCEzd6IfqTwUQcNXgEtmmQ6DlRrC1hrSrBnCZPokRrDHjw==", + "dev": true, + "license": "MIT" }, "node_modules/uri-js": { "version": "4.4.1", diff --git a/package.json b/package.json index 49d3a4e..aa789a1 100644 --- a/package.json +++ b/package.json @@ -110,7 +110,7 @@ }, "devDependencies": { "@types/mocha": "^10.0.10", - "@types/node": "^18.19.74", + "@types/node": "^20.14.8", "@types/vscode": "^1.82.0", "@typescript-eslint/eslint-plugin": "^8.22.0", "@typescript-eslint/parser": "^8.22.0", diff --git a/renovate.json b/renovate.json index c4f5219..c062e42 100644 --- a/renovate.json +++ b/renovate.json @@ -5,5 +5,12 @@ "git-submodules": { "enabled": true }, + "packageRules": [ + { + "description": "Use types of the minimum supported Node version", + "matchPackageNames": ["@types/node"], + "allowedVersions": "<21" + } + ], "schedule": ["on Wednesday"] } From c5a16e1460f869552eb30dda3d1015e032d49d9c Mon Sep 17 00:00:00 2001 From: Grigory Date: Fri, 7 Feb 2025 03:47:56 +0500 Subject: [PATCH 2/3] use latest lts node in ci --- .github/workflows/test.yml | 5 ++--- package-lock.json | 20 +++++++++----------- package.json | 2 +- renovate.json | 2 +- 4 files changed, 13 insertions(+), 16 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 0653891..3a9db70 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -10,13 +10,12 @@ on: jobs: test: - name: Test on node ${{ matrix.node }} and ${{ matrix.os }} + name: Test on ${{ matrix.os }} runs-on: ${{ matrix.os }} strategy: matrix: - node: [20, 22] os: - ubuntu-latest - windows-latest @@ -30,7 +29,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v4 with: - node-version: ${{ matrix.node }} + node-version: lts/* - name: Start xvfb run: | /usr/bin/Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 & diff --git a/package-lock.json b/package-lock.json index 714c487..b1c2071 100644 --- a/package-lock.json +++ b/package-lock.json @@ -13,7 +13,7 @@ }, "devDependencies": { "@types/mocha": "^10.0.10", - "@types/node": "^20.14.8", + "@types/node": "^18.19.74", "@types/vscode": "^1.82.0", "@typescript-eslint/eslint-plugin": "^8.22.0", "@typescript-eslint/parser": "^8.22.0", @@ -502,13 +502,12 @@ "dev": true }, "node_modules/@types/node": { - "version": "20.17.17", - "resolved": "https://registry.npmjs.org/@types/node/-/node-20.17.17.tgz", - "integrity": "sha512-/WndGO4kIfMicEQLTi/mDANUu/iVUhT7KboZPdEqqHQ4aTS+3qT3U5gIqWDFV+XouorjfgGqvKILJeHhuQgFYg==", + "version": "18.19.74", + "resolved": "https://registry.npmjs.org/@types/node/-/node-18.19.74.tgz", + "integrity": "sha512-HMwEkkifei3L605gFdV+/UwtpxP6JSzM+xFk2Ia6DNFSwSVBRh9qp5Tgf4lNFOMfPVuU0WnkcWpXZpgn5ufO4A==", "dev": true, - "license": "MIT", "dependencies": { - "undici-types": "~6.19.2" + "undici-types": "~5.26.4" } }, "node_modules/@types/vscode": { @@ -5716,11 +5715,10 @@ } }, "node_modules/undici-types": { - "version": "6.19.8", - "resolved": "https://registry.npmjs.org/undici-types/-/undici-types-6.19.8.tgz", - "integrity": "sha512-ve2KP6f/JnbPBFyobGHuerC9g1FYGn/F8n1LWTwNxCEzd6IfqTwUQcNXgEtmmQ6DlRrC1hrSrBnCZPokRrDHjw==", - "dev": true, - "license": "MIT" + "version": "5.26.5", + "resolved": "https://registry.npmjs.org/undici-types/-/undici-types-5.26.5.tgz", + "integrity": "sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA==", + "dev": true }, "node_modules/uri-js": { "version": "4.4.1", diff --git a/package.json b/package.json index aa789a1..49d3a4e 100644 --- a/package.json +++ b/package.json @@ -110,7 +110,7 @@ }, "devDependencies": { "@types/mocha": "^10.0.10", - "@types/node": "^20.14.8", + "@types/node": "^18.19.74", "@types/vscode": "^1.82.0", "@typescript-eslint/eslint-plugin": "^8.22.0", "@typescript-eslint/parser": "^8.22.0", diff --git a/renovate.json b/renovate.json index c062e42..4f27aef 100644 --- a/renovate.json +++ b/renovate.json @@ -9,7 +9,7 @@ { "description": "Use types of the minimum supported Node version", "matchPackageNames": ["@types/node"], - "allowedVersions": "<21" + "allowedVersions": "=18" } ], "schedule": ["on Wednesday"] From bdae3616cd082f75d5439122a15b3229ee64d84e Mon Sep 17 00:00:00 2001 From: Hong Xu Date: Fri, 7 Feb 2025 20:59:37 -0800 Subject: [PATCH 3/3] Add comments --- .github/workflows/test.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3a9db70..b0d9bed 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -29,6 +29,13 @@ jobs: - name: Setup Node uses: actions/setup-node@v4 with: + # In CI, this Node is only used to + # - Install dependencies, + # - Run tools like typescript and eslint + # - Execute the runTests function of the @vscode/test-electron package + # + # Therefore, it doesn't have to match the Node version supported by + # VSCode. node-version: lts/* - name: Start xvfb run: |