Fixes to get token colour definitions to work.#42
Closed
obscherler wants to merge 3 commits intoedly-io:ahmed-arb/test-design-tokensfrom
Closed
Fixes to get token colour definitions to work.#42obscherler wants to merge 3 commits intoedly-io:ahmed-arb/test-design-tokensfrom
obscherler wants to merge 3 commits intoedly-io:ahmed-arb/test-design-tokensfrom
Conversation
Author
|
Please disregard, I started over in #43 and got much further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-tokensscript so that tokens are processed;--pgn-color-primaryvariable to--pgn-color-primary-baseso that the variables defined by the token file have an effect.I think if the SCSS variables were replaced with the
paragon replace-variablescommand instead of manually, with an adequate token file, it would have been automatic (color.primary.basehas"source": "$primary", so$primarywould be replaced by--pgn-color-primary-base.)