Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS support documentation and core-coreutils requirement #8

Open
2fd5 opened this issue Jan 31, 2022 · 2 comments
Open

MacOS support documentation and core-coreutils requirement #8

2fd5 opened this issue Jan 31, 2022 · 2 comments
Assignees
@borancar

Comments

@2fd5
Copy link

2fd5 commented Jan 31, 2022

https://github.com/Qarik-Group/disruptor/blob/c8e18640f3c5e8944e6897cecc40a341d3c4d187/scripts/shell.sh#L5

There is assumption that core-coreutils is installed and in $PATH. Shall we have that documented and if so where can I document it ?

Alternatively we could add a check for greadlink in shell.sh and display appropriate message...
@2fd5 2fd5 changed the title MacOS support documentation MacOS support documentation and core-coreutils requirement Jan 31, 2022
@2fd5 2fd5 changed the title MacOS support documentation and core-coreutils requirement MacOS support documentation and core-coreutils requirement Jan 31, 2022
@borancar
Copy link
Collaborator

Good point, can easily drop the assumption with a check and helpful message how to install coreutils.

@borancar borancar self-assigned this Jan 31, 2022
@2fd5
Copy link
Author

2fd5 commented Feb 1, 2022 •
edited
Loading

For future reference

MacPorts
sudo port install coreutils

Homebrew
brew install coreutils

@r2r-dev r2r-dev mentioned this issue Mar 21, 2022
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@borancar borancar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@borancar @2fd5