Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use credentials store for docker login from travis #4

Open
eine opened this issue Apr 13, 2018 · 2 comments
Open

Use credentials store for docker login from travis #4

eine opened this issue Apr 13, 2018 · 2 comments
Labels
CI: travis help wanted Extra attention is needed

Comments

@eine
Copy link
Owner

eine commented Apr 13, 2018

WARNING! Your password will be stored unencrypted in /home/travis/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store
@eine eine added help wanted Extra attention is needed CI: travis labels Apr 13, 2018
@Nic30
Copy link
Collaborator

Nic30 commented Apr 13, 2018

For what the password is for?

docker has secrets https://docs.docker.com/engine/swarm/secrets/#intermediate-example-use-secrets-with-a-nginx-service

and travis itself can ecrypt keys https://docs.travis-ci.com/user/encryption-keys/

@eine
Copy link
Owner Author

eine commented Apr 13, 2018

It is used during the deploy task of some travis-ci jobs, in order to push docker images to dockerhub. E.g.:

  • Pull ghdl/ext:vunit. No credentials required.
  • Build ghdl/ext:ide. No credentials required.
  • Push ghdl/ext:ide to dockerhub. Credentials required.

Actually, we are using the travis encryption feature you referred. More precisely, this is the same info worded for Docker: https://docs.travis-ci.com/user/docker/#Pushing-a-Docker-Image-to-a-Registry
And this is a equivalent minimum example: https://docs.travis-ci.com/user/build-stages/share-docker-image/

However, the message I pasted in the first comment is shown in every build. See lines 529-531: https://travis-ci.org/1138-4EB/hwd-ide/jobs/366242954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: travis help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants