Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] don't mix helper logic with business logic #41

Open
DebVortex opened this issue May 15, 2019 · 0 comments
Open

[Refactor] don't mix helper logic with business logic #41

DebVortex opened this issue May 15, 2019 · 0 comments

Comments

@DebVortex
Copy link

There are several functions and modules in the helper directory that gets passed down the bot. In the end, the helper function even sends out messages via the bot.

I suggest to remove all occurrences of the bot from any helper function and let the bot functions only get called inside the handler functions. This way, the code can be even more DRY and would allow reuse of existing functions.

For example, currently the inline_query can not use the "message formating feature" of the sendDepartureMessage, because it automatically sends out a message which.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant