Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Paella player control bar too high #1276

Open
oas777 opened this issue Nov 6, 2024 · 15 comments
Open

Mobile: Paella player control bar too high #1276

oas777 opened this issue Nov 6, 2024 · 15 comments
Labels
area:player Paella and its integration in Tobira kind:bug Bug

Comments

@oas777
Copy link
Collaborator

oas777 commented Nov 6, 2024

Seems to be two lines where it should be one.

image

Maybe it would be a good idea to disable the "Show slides" button also which is not really helpful.

@oas777
Copy link
Collaborator Author

oas777 commented Nov 6, 2024

Oh, and some other Paella issues at least on my device:

  • Control doesn't disappear once used.
  • Pressing the "Option" symbol makes a overlay appear so that you cannot "unpress" the symbol.
  • Fullscreen doesn't work.

Hope these are problems with this deployment ...

@owi92
Copy link
Member

owi92 commented Nov 7, 2024

We could hide "show slides" and probably also make the other icons shrink when on smaller screens.
In order for control to disappear, you need to tap outside the player. If that's not a good solution, I think it would need to be fixed in paella.

I can't reproduce the Options thing on my device, so that might be specific to iOS. Fullscreen not working definitely is.

@owi92 owi92 added the area:player Paella and its integration in Tobira label Nov 7, 2024
@oas777
Copy link
Collaborator Author

oas777 commented Nov 7, 2024

The control button being covered by the overly for "control" seems to be a result of the two lines created. Do we solve this

  • by reducing the size of icons (not very comfortable on a small screen) or
  • getting rid of icons? If so, I suggest +/- 10s could go

@LukasKalbertodt
Copy link
Member

  • Buttons in two lines: that does not happen on my iPhone 13 Mini, but I have seen this before and can easily reproduce it by shrinking the browser window size enough. Yes we should fix that. I don't mind shrinking the buttons a bit.
    • Removing +-10s: it would be nice if Paella supported the YouTube double-tab gesture on the left/right side of the video for this functionality. Then we could easily remove those buttons.
  • Control bar: can reproduce, but it doesn't bother me that much. Clicking outside of the player or on the video does fix it. But yeah would have to be fixed in Paella.
  • Option button problem: also cannot reproduce, but as you said, probably result of the two lines.
  • Fullscreen: Dang, how did this break again. Thanks for noticing. It's very hard to write automated tests for this. Maybe we should have a checklist of manual tests we need to perform before each release...

@oas777
Copy link
Collaborator Author

oas777 commented Nov 7, 2024

I'm about to contact UPV about the slide segmenter, is there anything else I should mention?

@LukasKalbertodt
Copy link
Member

The problem with the two lines is even worse for videos with subtitles: https://tobira.opencast.org/v/KrlVO3Ks4bG?list=Lwiz32KAK0i

Keeping all icons in one line on our minimum supported screen width of 320px is... hard. Not sure if we can achieve this by just making everything smaller. Maybe at that point one actually has to hide some elements.

I'm about to contact UPV about the slide segmenter, is there anything else I should mention?

Can't think of anything right now. Maybe we need to talk to them regarding fullscreen mode, but I'm not sure yet if the bug is on our or their side. Have to investigate first.

@owi92
Copy link
Member

owi92 commented Nov 7, 2024

I'm about to contact UPV about the slide segmenter, is there anything else I should mention?

David asked me a while ago to open this issue: polimediaupv/paella-core#372.
And there are two other open issues related to the slide segments (which I suspect you would mention anyway, but for completeness, here they are): polimediaupv/paella-slide-plugins#7, polimediaupv/paella-slide-plugins#8.

@oas777
Copy link
Collaborator Author

oas777 commented Nov 7, 2024

I'm all in favor of getting rid of icons, just like "Show slides" and maybe even "Video layout" with dual video videos. And while we're at it: Who can actually see/use those "in-video" control elements?
image

@owi92
Copy link
Member

owi92 commented Nov 7, 2024

Who can actually see/use those "in-video" control elements?

They become opaque when you're hovering over the video, but on mobile you need to tap inside the video instead (but not the control bar, above that).

@oas777
Copy link
Collaborator Author

oas777 commented Nov 7, 2024

Let me rephrase that question: Why are we offering the full range of features Paella has in mobile, where space is limited? I know there's larger devices, but instead of making icons even smaller and "in-video" elements cluttering the UI, let's get rid of some stuff in mobile.

@owi92
Copy link
Member

owi92 commented Nov 7, 2024

I see your point. We don't need to offer everything, but users should at least have some control over which stream they want to see.
Or we just default to showing slides only, as I suspect those will be more important than the view of the lecturer in most cases.

Please tell us which elemets you want to get rid of on mobile screens and which ones you think should be kept.

Edit: You mentioned +/- 10s already, I'd be fine with omitting those. And I would probably still shrink the icons a bit to make the control bar smaller.

@oas777
Copy link
Collaborator Author

oas777 commented Nov 7, 2024

We don't need to offer everything, but users should at least have some control over which stream they want to see.

They can do that video the "Video layout" button under "Options" in the control bar - so we're offering the same function twice on the size of a stamp.

@oas777
Copy link
Collaborator Author

oas777 commented Nov 7, 2024

Please tell us which elemets you want to get rid of on mobile screens and which ones you think should be kept.

I suggested some, but would like to hear others - including yourself.

@owi92
Copy link
Member

owi92 commented Nov 7, 2024

I suggested some, but would like to hear others - including yourself.

As a user, I'd be fine with immediately accessible controls/display for just Play/Pause, Timestamp and Volume - everything else would be fine under the settings menu (which would get crammed, but that's fine imo).

Well maybe also add the fullscreen button (if that is working...).

@dagraf
Copy link
Collaborator

dagraf commented Nov 12, 2024

Hiding buttons: I regularly use the +/- 10s buttons. Therefore, I would vote to keep them. Also because accurate scrolling in the timeline is quite hard on small screen and with clumsy fingers.

My suggestions:

  • Keep and shrink a bit: Play/Pause, +/- 10s, Settings-Wheel, Fullscreen
  • Move the rest to settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:player Paella and its integration in Tobira kind:bug Bug
Projects
None yet
Development

No branches or pull requests

4 participants