feature/config folder arg #1580
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hared instances of repository
This allows the build to source the configuration prior to cloning and building
docs-assembler repo init-config
docs-assembler repo clone-all
docs-assembler repo build-all
On production we can lock the configuration to a commit using `--git-ref sha`.
ConfigurationFileProvider will look at
- {pwd}/config, development
- {app_data}/config, (where init-config clones too)
- embedded sources
We also now log the configuration source and in case of app_data also the git reference.
reakaleek
approved these changes
Jul 18, 2025
| [EnumExtensions] | ||
| public enum ConfigurationSource | ||
| { | ||
| Local, |
There was a problem hiding this comment.
Can we use local and put the config in elastic/docs-internal-workflows?
There was a problem hiding this comment.
We could, as source of truth or as a copy?
I think we want the source of truth to remain in docs-builder.
There was a problem hiding this comment.
Maybe it's just me. But I like to think that the config is close to the place where it's being deployed from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the build to source the configuration prior to cloning and building
docs-assembler repo init-config
docs-assembler repo clone-all
docs-assembler repo build-all
On production we can lock the configuration to a commit using
--git-ref sha.I think we want to automate opening PR's to update that sha to the last commit on our
configfolder. We can then merge it once we know staging is still good.ConfigurationFileProvider will look at
We also now log the configuration source and in case of app_data also the git reference.