Skip to content

Commit ce27e08

Browse files
authored
make retries in pip and go get extra shell compatible (#14282)
the use of ranges (e.g. {0..5}) or seq (e.g. $(seq 0 5)) may not correctly in some systems, so let's just have a plain list of elements for the loop to go through.
1 parent ff9f1e5 commit ce27e08

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

docker/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ venv: requirements.txt
148148
pyenv install --skip-existing $(PY_VERSION) &&\
149149
pyenv local $(PY_VERSION) &&\
150150
python3 -mvenv venv && \
151-
for i in $(seq 0 5); do sleep "$i"; pip install -r requirements.txt && break; done &&\
151+
for i in 0 1 2 3 4 5; do sleep "$i"; pip install -r requirements.txt && break; done &&\
152152
touch venv
153153

154154
# Make a Golang container that can compile our env2yaml tool.

docker/data/golang/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
FROM golang:1
2-
RUN go env -w GO111MODULE=off && (for i in $(seq 0 5); do sleep "$i"; go get gopkg.in/yaml.v2 && break; done)
2+
RUN go env -w GO111MODULE=off && (for i in 0 1 2 3 4 5; do sleep "$i"; go get gopkg.in/yaml.v2 && break; done)
33
WORKDIR /usr/local/src/env2yaml
44
CMD ["go", "build"]

0 commit comments

Comments
 (0)