Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly attribute request's method as HEAD or GET in OT traces when tracing HTTP requests #1661

Open
alco opened this issue Sep 10, 2024 · 0 comments

Comments

@alco
Copy link
Member

alco commented Sep 10, 2024

Background: we've recently added support for HEAD requests (#1645) which is implemented by converting any incoming HEAD request into a GET one. That means that Electric builds a response body for such requests even though it's discarded later.

While it might not be a problem performance-wise, and handling HEAD requests this way makes sure the response headers are correct since there's a single execution path for both types of requests, we should still use the original request method in telemetry data that Electric exports (via Open Telemetry and otherwise), so that we can see on performance charts if HEAD requests aren't actually as cheap as we hope they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant