-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial spans for opentelemetry #1664
Comments
A few notes from testing just now: We'll want For replication log spans, we need spans created for the code that updates the shape & sends it to any subscribers. That way we can see the tree of a replication log coming to Electric & then all subsequent work to update shapes & subscribers. |
I also think we should just have one shape for all shape requests — a simpler name would be nice too — e.g. |
We need an attribute to distinguish between requests that go into long polling or just immediately respond. |
We need attributes about the shape — Also the size of the response body (aka the size of the shape) |
Common queries will include:
|
|
yeah that works too — true for normal responses and false for long polling |
We have the initial setup of opentelemetry done but let's now add the following basic spans & attributes (not exhaustive, whoever does this feel free to add more that seem right):
url
The text was updated successfully, but these errors were encountered: