-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TypeScript definitions #54
Conversation
@malept any news regarding this? |
Since there is no update to this, I will re-open DefinitelyTyped/DefinitelyTyped#54338. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience.
Can you please add tests for the TypeScript definitions (via tsd
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I have a naming suggestion for the Options interface.
Also, can you avoid squashing all of your commits? It makes it difficult to review new changes. The PR will be squashed at the end. |
Sure. Here are the two changes:
You can see the changes by clicking on "force-pushed" in the message "ffflorian force-pushed the ffflorian:feat/types branch...". |
Co-authored-by: Mark Lee <[email protected]>
Co-authored-by: Mark Lee <[email protected]>
@malept can we continue? 🙂 |
Can you merge the main branch into this PR so CI actually runs? |
Unfortunately tsd needs Node.js >=12. |
I guess this means that this is a breaking change. |
Well, tsd is used only for the test, so in my opinion it's not a breaking change because the tests are not needed for the consumer. |
Eh, might as well update this package anyway. I'll go do that in a separate PR |
Now that Node 12 is required since 4.0.0: Was this PR closed by accident? It would be nice having in-package types. |
Note: I just updated the types at DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#63902 |
This closes #48.