Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision While Setting Versions #1366

Open
1 of 2 tasks
dsanders11 opened this issue Jun 2, 2023 · 0 comments
Open
1 of 2 tasks

Collision While Setting Versions #1366

dsanders11 opened this issue Jun 2, 2023 · 0 comments
Labels
area:versions 🪲 bug Something isn't working

Comments

@dsanders11
Copy link
Member

dsanders11 commented Jun 2, 2023

Under certain circumstances, such as opening an example from the docs, multiple versions end up being set in parallel - the original version on startup, immediately followed by the version specified for the example being loaded. Once they're running in parallel, they can collide on setting the active version on disk with fiddle-core.

This situation could be improved by:

  • Not unzipping a version until it is run (fix: don't install version until run #1367)
  • Keeping track of any in-progress versions being set and the ability to abort them - ideally also aborting the download, but that is not supported by @electron/get at this time. Aborting an in-progress version being set should at least not conflict with any subsequent versions set.
Screenshot 2023-06-01 at 10 32 41 PM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:versions 🪲 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant