Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect ABI for Electron stable v15 #112

Closed
johnpyp opened this issue Oct 6, 2021 · 1 comment
Closed

Incorrect ABI for Electron stable v15 #112

johnpyp opened this issue Oct 6, 2021 · 1 comment

Comments

@johnpyp
Copy link

johnpyp commented Oct 6, 2021 •
edited
Loading

When using electron: "15.1.1", the process.modules.versions returns abi 98, but node-abi returns 89 for it still, which causes native modules rebuilds to fetch abi 89 builds and breaks those dependencies.

Is this an issue that would be remedied just from a new release?
@johnpyp
Copy link
Author

johnpyp commented Oct 6, 2021

Nevermind, it seems I was mistaken. The version I was checking with was on 2.x.

@johnpyp johnpyp closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johnpyp