Still no entry for Node 33.0.2

[cseickel]

This is a repeat of #189. It was closed as fixed but no fix was actually made that I can see. There has also been no new releases since that issue was opened. If code was checked in that should fix it, maybe it just needs to be released?

[LordTocs]

This is still an issue for me, the latest node-abi still doesn't work with 33.0.2. Is the electron-node-abi-updater[bot] working? I don't see a commit with an update to the registry.

[cseickel]

@VerteDinde it doesn't seem like the fix you tried to make for #189 had any effect.

[dsanders11]

@cseickel, I can't reproduce your issue, it seems to work fine for Electron v33.0.2.

> const nodeAbi = require('node-abi')
> nodeAbi.getAbi('33.0.2, 'electron')
'130'

[cseickel]

My apologies @dsanders11, when I dug deeper I realized that I had an older version of node-abi. 3.60 was the version implicitly used as a dependency of electron forge 7.5.1. When I explicitly installed node-abi and got version 3.71.0, then I got the correct answer when looking up Electron v33.0.2.

Explicitly installing node-abi does not solve my problem though. The real issue here is that electron-forge uses [email protected], which uses [email protected], which is the true cause of my problem. 3.7.1 is the latest version of rebuild, so I guess that means electron forge is just not compatible with the 33.x series of electron releases yet.

All of this is not a fault of this project, so I will close the issue. Hopefully the above will help others troubleshoot in the future.

[MarshallOfSound]

@cseickel rebuild / forge does not depend on a specific version of node-abi, they depend on a range...

You can update the transitive dependency yourself quite easily with either npm update node-abi or yarn upgrade node-abi depending on the package manager you use.

Forge and Rebuild won't publish new versions every time node-abi does, that would be absurd, instead apps should update their dependency tree accordingly.

[cseickel]

Thanks for the info @MarshallOfSound.

I use yarn for the project with the issue and yarn upgrade node-abi does not actually do anything, it will stay with 3.60.0. Explicitly installing node-abi will just give me an additional version but does not affect what rebuild uses.

What worked for me was deleting node-modules/ and yarn.lock and re-installing. On a fresh install, I got the latest version of node-abi and only the latest version. I assume 3.60.0 was just the latest version the last time I did a fresh install.

[MarshallOfSound]

Using yarn@1 you can use a tool I wrote for this. npx uuaw@latest node-abi