Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not detect abi for version 11.0.0 and runtime electron. #97

Closed
BellezaEmporium opened this issue Nov 17, 2020 · 4 comments
Closed

Comments

@BellezaEmporium
Copy link

BellezaEmporium commented Nov 17, 2020

It seems that node-abi does not support correctly the latest electron version, named 11.

Here is, for example, the full error brought up by "electron-rebuild" :

An unhandled error occurred inside electron-rebuild
Could not detect abi for version 11.0.0 and runtime electron. Updating "node-abi" might help solve this issue if it is a new release of electron

@adriencohen
Copy link

The following patch with patch-package (https://www.npmjs.com/package/patch-package) should do the trick while waiting for an update of node-abi

diff --git a/node_modules/node-abi/abi_registry.json b/node_modules/node-abi/abi_registry.json
index 852f500..632a1ae 100644
--- a/node_modules/node-abi/abi_registry.json
+++ b/node_modules/node-abi/abi_registry.json
@@ -88,5 +88,12 @@
     "lts": false,
     "future": true,
     "abi": "85"
+  },
+  {
+    "runtime": "electron",
+    "target": "11.0.0",
+    "lts": false,
+    "future": true,
+    "abi": "85"
   }
 ]

@julianxhokaxhiu
Copy link

What about opening a PR for this? Shall I do it?

@adriencohen
Copy link

@julianxhokaxhiu pretty sure it'll be done automatically tonight by the Github Action

@BellezaEmporium
Copy link
Author

Can confirm that latest release fixes this issue. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants