Experimental Module API Additions #30863
Open
+517
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we don't have to pass it into RoomView
A bit less flexible but probably simpler and will help keep things actually consistent rather than just allowing modules to stick any JSX into the space panel (which means they also have to worry about styling if they *do* want it to be consistent).
and manage which one is selected, allowing module "spaces" to be considered spaces
which didn't really seem to have any point as it was only called from one place
Since it's passed through context
This is now accessed through class field
t3chguy
reviewed
Oct 31, 2025
t3chguy
reviewed
Oct 31, 2025
| @@ -0,0 +1,50 @@ | |||
| /* | |||
| Copyright 2025 New Vector Ltd. | |||
There was a problem hiding this comment.
Well, the code was written while we were NVL... I would guess it should be this rather than when it's merged.
There was a problem hiding this comment.
From chat I saw in the room around the time of the change it is retroactive and we need to add Element Creations Ltd to all existing files at some point too
t3chguy
reviewed
Oct 31, 2025
| @@ -0,0 +1,33 @@ | |||
| /* | |||
| Copyright 2025 New Vector Ltd. | |||
t3chguy
reviewed
Oct 31, 2025
| }; | ||
|
|
||
| export type SpaceKey = MetaSpace | Room["roomId"]; | ||
| export type SpaceKey = string; |
There was a problem hiding this comment.
Can we have comments now that the semantics are lost from the type
and fix else block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs element-hq/element-modules#79
This will pass type checks once Midhun's stack of PRs is merged into it, but please review first so we can review the chunks in isolation.
Checklist
public/exportedsymbols have accurate TSDoc documentation.