Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow simultaneous opening of projects with parent-child relationship #1500

Merged
merged 9 commits into from
Feb 4, 2025

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Dec 24, 2024

Fixes #1494

  • Check parents and children before opening a new project folder
  • Fix consequent race condition between restoring project folders and restoring open documents

Because restoring a project folder now occurs in a separate thread it is necessary to ensure that all project folders are restored before starting to restore open documents otherwise documents are not correctly assigned to a project on startup.

@jeremypw jeremypw marked this pull request as ready for review January 21, 2025 10:51
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

# Conflicts fixed:
#	po/POTFILES
#	src/meson.build
@jeremypw jeremypw enabled auto-merge (squash) February 4, 2025 12:14
@jeremypw jeremypw merged commit 04ff180 into master Feb 4, 2025
4 of 6 checks passed
@jeremypw jeremypw deleted the jeremypw/fix-ambiguous-project branch February 4, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code crashes when both a folder and its parent are open as projects and a document present in both is opened
2 participants