8.0.0 FTBFS with GCC 14 (-Wimplicit-function-declaration)

[bobby285271]

What Happened?

👋

With 79d8049, all plugins failed to build with GCC 14.2.1 (and libpeas-2 2.0.7, vala 0.56.18) with:

error: implicit declaration of function 'scratch_services_activatable_plugin_set_object'; did you mean 'scratch_services_activatable_plugin_get_object'? [-Wimplicit-function-declaration]
  755 |                 scratch_services_activatable_plugin_set_object ((ScratchServicesActivatablePlugin*) self, g_value_get_object (value));
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                 scratch_services_activatable_plugin_get_object

Here are the full logs.

Steps to Reproduce

1. Build with GCC 14

Expected Behavior

Builds

OS Version

NixOS unstable

Session Type

Classic Session (X11, This is the default)

Software Version

Latest release (I have run all updates)

Log Output

full logs.

Hardware Info

No response

[jeremypw]

Code v8.0.0 is building on OS8 using GCC v13.3.0 and libpeas-2 v2.0.1 with valac v0.56.17. I'll have a look at the logs and see if I can identify the problem on GCC v14.2.1

[jeremypw]

@bobby285271 Can you try #1606? I do not have the versions of gcc, libpeas2 and valac you are using so not sure exactly what the problem is.

[bobby285271]

Yes that works for me! 💯