Dialogs get restored at unreasonable sizes

[danirabbit]

What Happened?

Dialog windows like in Code or Inkscape get saved and restored at unreasonably large sizes

Steps to Reproduce

I'm not entirely sure how to reproduce, it doesn't happen every time afaict, but see for example elementary/code#1673

Expected Behavior

Personally, I don't think Gala should be saving any window sizes. This should be up to applications to decide if it makes sense for them to save and restore window sizes and which windows etc. Apps know the context of their windows and if it makes sense to save their sizes or not

At the very least we shouldn't be saving dialog sizes. I suppose a problem is we can't always tell what is a dialog if a window is non-modal, which preferences windows are often very intentionally non-modal. So that kind of leads me back to, we shouldn't save window sizes in Gala because we can't know if that's actually a good idea.

OS Version

8.x (Circe)

OS Architecture

amd64 (on most hardwares)

Session Type

Secure Session (Wayland)

Software Version

Latest release (I have run all updates)

Log Output

Hardware Info

No response

[leolost2605]

Yeah, I agree. Especially since the Wayland session save and restore will arrive in os 9 so at the latest then we should probably remove our custom save and restore.