rm unused fn

Author: leonstafford

src/HTMLProcessor.php

@@ -771,45 +771,6 @@ public function detectUnchangedPlaceholderURLs( string $processed_html ) : strin
         return $processed_html;
     }
 
-    // TODO: kill this fn, should not be needed anymore
-    public function rewriteUnchangedPlaceholderURLs(
-        string $processed_html,
-        string $placeholder_url,
-        string $destination_url,
-        string $rewrite_rules
-    ) : string {
-        // add base URL to rewrite_rules
-        $rewrite_rules .=
-            PHP_EOL .
-                $placeholder_url . ',' .
-                $destination_url;
-
-        $rewrite_from = [];
-        $rewrite_to = [];
-
-        $rewrite_rules = explode(
-            "\n",
-            str_replace( "\r", '', $rewrite_rules )
-        );
-
-        foreach ( $rewrite_rules as $rewrite_rule_line ) {
-            if ( $rewrite_rule_line ) {
-                list($from, $to) = explode( ',', $rewrite_rule_line );
-
-                $rewrite_from[] = $from;
-                $rewrite_to[] = $to;
-            }
-        }
-
-        $rewritten_source = str_replace(
-            $rewrite_from,
-            $rewrite_to,
-            $processed_html
-        );
-
-        return $rewritten_source;
-    }
-
     public function rewriteEscapedURLs( string $processed_html ) : string {
         // NOTE: fix input HTML, which can have \ slashes modified to %5C
         $processed_html = str_replace(

tests/HTMLProcessorTest.php

@@ -287,89 +287,6 @@ public function rewritePlaceholdersProvider() {
         ];
     }
 
-    /**
-     * @covers StaticHTMLOutput\HTMLProcessor::__construct
-     * @covers StaticHTMLOutput\HTMLProcessor::rewriteUnchangedPlaceholderURLs
-     * @dataProvider unchangedURLsProvider
-     */
-    public function testRewritingRemainingPlaceholders(
-       $placeholder_url,
-       $destination_url,
-       $rewrite_rules,
-       $processed_html,
-       $exp_result
-       ) {
-
-        $html_processor = new HTMLProcessor(
-            false, // $remove_conditional_head_comments = false
-            false, // $remove_html_comments = false
-            false, // $remove_wp_links = false
-            false, // $remove_wp_meta = false
-            '', // $rewrite_rules = false
-            '', // $base_url
-            '', // $selected_deployment_option = 'folder'
-            '', // $wp_site_url
-            '' // $wp_uploads_path
-        );
-
-        $this->assertEquals(
-            $exp_result,
-            $html_processor->rewriteUnchangedPlaceholderURLs(
-                $processed_html,
-                $placeholder_url,
-                $destination_url,
-                $rewrite_rules
-            )
-        );
-    }
-
-    public function unchangedURLsProvider() {
-        return [
-            'http destination URL with trailing slash and trailing chars' => [
-                'http://PLACEHOLDER.wpsho',
-                'https://somedomain.com',
-                '',
-                '<a href="http://PLACEHOLDER.wpsho/banana.jpg">Link to some file</a>',
-                '<a href="https://somedomain.com/banana.jpg">Link to some file</a>',
-            ],
-            'http destination URL with trailing slash' => [
-                'http://PLACEHOLDER.wpsho',
-                'https://somedomain.com',
-                '',
-                '<a href="http://PLACEHOLDER.wpsho/">Link to some file</a>',
-                '<a href="https://somedomain.com/">Link to some file</a>',
-            ],
-            'http destination URL without trailing slash' => [
-                'http://PLACEHOLDER.wpsho',
-                'https://somedomain.com',
-                '',
-                '<a href="http://PLACEHOLDER.wpsho">Link to some file</a>',
-                '<a href="https://somedomain.com">Link to some file</a>',
-            ],
-            'https destination URL with trailing slash and trailing chars' => [
-                'http://PLACEHOLDER.wpsho',
-                'https://somedomain.com',
-                '',
-                '<a href="http://PLACEHOLDER.wpsho/banana.jpg">Link to some file</a>',
-                '<a href="https://somedomain.com/banana.jpg">Link to some file</a>',
-            ],
-            'https destination URL with trailing slash' => [
-                'http://PLACEHOLDER.wpsho',
-                'https://somedomain.com',
-                '',
-                '<a href="http://PLACEHOLDER.wpsho/">Link to some file</a>',
-                '<a href="https://somedomain.com/">Link to some file</a>',
-            ],
-            'https destination URL without trailing slash' => [
-                'http://PLACEHOLDER.wpsho',
-                'https://somedomain.com',
-                '',
-                '<a href="http://PLACEHOLDER.wpsho">Link to some file</a>',
-                '<a href="https://somedomain.com">Link to some file</a>',
-            ],
-        ];
-    }
-
     /**
      * @covers StaticHTMLOutput\HTMLProcessor::__construct
      * @covers StaticHTMLOutput\HTMLProcessor::detectEscapedSiteURLs