Fix missing require using required: true meta

Author: sabiwara

lib/elixir/lib/regex.ex

@@ -1021,9 +1021,10 @@ defmodule Regex do
           {:ok, exported} = :re.compile(regex.source, [:export] ++ regex.opts)
 
           quote do
-            require Regex
             Regex.__import_pattern__(unquote(Macro.escape(exported)))
           end
+          # we now that the Regex module is defined at this stage, so this macro can be safely called
+          |> Macro.update_meta(&([required: true] ++ &1))
 
         # TODO: Remove this when we require Erlang/OTP 28.1+
         # OTP 28.0 works in degraded mode performance-wise, we need to recompile from the source
@@ -1049,7 +1050,7 @@ defmodule Regex do
   @doc false
   defmacro __import_pattern__(pattern) do
     if __CALLER__.context in [:match, :guard] do
-      raise ArgumentError, "escaped"
+      raise ArgumentError, "escaped Regex structs are not allowed in match or guards"
     end
 
     quote do

lib/elixir/test/elixir/macro_test.exs

@@ -167,14 +167,9 @@ defmodule MacroTest do
                [],
                [
                  __struct__: Regex,
-                 re_pattern: {
-                   :__block__,
-                   [],
-                   [
-                     {:__assert_assert_no_match_or_guard_scope__, _, _},
-                     {{:., [], [:re, :import]}, [], [{:{}, [], [:re_exported_pattern | _]}]}
-                   ]
-                 },
+                 re_pattern:
+                   {{:., [], [{:__aliases__, _, [:Regex]}, :__import_pattern__]},
+                    [required: true], [{:{}, [], [:re_exported_pattern | _]}]},
                  source: "foo",
                  opts: []
                ]

lib/elixir/test/elixir/regex_test.exs

@@ -32,7 +32,7 @@ defmodule RegexTest do
   test "module attribute in match context" do
     assert_raise(
       ArgumentError,
-      ~r/invalid expression in match, an escaped Regex is not allowed in patterns such as function clauses/,
+      ~r/escaped Regex structs are not allowed in match or guards/,
       fn ->
         Code.eval_quoted(
           quote do