Registry.update -> Registry.update_value

Author: José Valim

examples/sojourn.exs

@@ -78,7 +78,7 @@ defmodule Registry.Sojourn do
     receive_time = System.system_time
 
     update =
-      Registry.update(name, key, fn _ ->
+      Registry.update_value(name, key, fn _ ->
         {-send_time, receive_time - send_time}
       end)
 

lib/registry.ex

@@ -259,14 +259,14 @@ defmodule Registry do
       iex> {:ok, _} = Registry.register(Registry.UpdateTest, "hello", 1)
       iex> Registry.lookup(Registry.UpdateTest, "hello")
       [{self(), 1}]
-      iex> Registry.update(Registry.UpdateTest, "hello", & &1 + 1)
+      iex> Registry.update_value(Registry.UpdateTest, "hello", & &1 + 1)
       {2, 1}
       iex> Registry.lookup(Registry.UpdateTest, "hello")
       [{self(), 2}]
 
   """
-  @spec update(registry, key, (value -> value)) :: {new_value :: term, old_value :: term} | :error
-  def update(registry, key, callback) when is_atom(registry) and is_function(callback, 1) do
+  @spec update_value(registry, key, (value -> value)) :: {new_value :: term, old_value :: term} | :error
+  def update_value(registry, key, callback) when is_atom(registry) and is_function(callback, 1) do
     case info!(registry) do
       {:unique, partitions, key_ets, _} ->
         key_ets = key_ets || key_ets!(registry, key, partitions)
@@ -283,7 +283,7 @@ defmodule Registry do
             :error
         end
       {kind, _, _, _} ->
-        raise ArgumentError, "Registry.update/3 is not supported for #{kind} registries"
+        raise ArgumentError, "Registry.update_value/3 is not supported for #{kind} registries"
     end
   end
 

test/registry_test.exs

@@ -54,13 +54,13 @@ defmodule RegistryTest do
       end
 
       test "updates current process value", %{registry: registry} do
-        assert Registry.update(registry, "hello", &raise/1) == :error
+        assert Registry.update_value(registry, "hello", &raise/1) == :error
         register_task(registry, "hello", :value)
-        assert Registry.update(registry, "hello", &raise/1) == :error
+        assert Registry.update_value(registry, "hello", &raise/1) == :error
 
         Registry.register(registry, "world", 1)
         assert Registry.lookup(registry, "world") == [{self(), 1}]
-        assert Registry.update(registry, "world", & &1 + 1) == {2, 1}
+        assert Registry.update_value(registry, "world", & &1 + 1) == {2, 1}
         assert Registry.lookup(registry, "world") == [{self(), 2}]
       end