From 72e79f343d372816c8488f46835d486e86ade205 Mon Sep 17 00:00:00 2001 From: Sipke Schoorstra Date: Sun, 4 Oct 2026 14:16:24 +0200 Subject: [PATCH 1/3] docs(reviewers): make Elsa 3 Code Review the only merge gate; all bots advisory --- .github/reviewers.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/reviewers.md b/.github/reviewers.md index 7fc0ba57..6825d289 100644 --- a/.github/reviewers.md +++ b/.github/reviewers.md @@ -7,17 +7,18 @@ Last verified: 2026-10-03 | Reviewer | Status | How to request | Notes | | --- | --- | --- | --- | | GitHub Copilot code review (`copilot-pull-request-reviewer[bot]`) | live | Add reviewer `@copilot`: `gh pr edit --add-reviewer @copilot` (GitHub CLI 2.88 or later) | Advisory. A `@copilot review` comment does not trigger it. Bot-authored PRs need the org policy that lets Copilot review them. | -| Greptile (`greptile-apps[bot]`) | not live (waived) | Comment `@greptileai` (once enabled here) | **Waived on this repository**: not required for merge, so nobody waits for a Greptile score. Installed, but does not review PRs here. | +| Greptile (`greptile-apps[bot]`) | not live | Comment `@greptileai` (once enabled here) | Advisory; not part of the merge gate (see Rules). Installed, but does not review PRs here. | | CodeRabbit (`coderabbitai[bot]`) | not live | Comment `@coderabbitai review` (once enabled here) | Not enabled for this repository. | | Cursor Bugbot | not live | Top-level PR comment `cursor review` (once enabled) | Must first be enabled in the Cursor dashboard. `cursor[bot]` comments on PRs come from Cursor cloud agents, not Bugbot. | | GitHub Code Quality (`github-code-quality[bot]`) | informational | Automatic; cannot be requested | CodeQL code-quality comments. Not an advisory pick and not part of the merge gate. | ## Rules -- Greptile is waived on this repository. Do not wait for or request a Greptile score. +- Greptile does not review PRs on this repository. Do not wait for or request a Greptile score. - Pick exactly one live advisory reviewer from the table (currently Copilot) and request it once the PR is open. Do not request a second reviewer. - If the picked reviewer declines or skips the PR, request another live reviewer if there is one; otherwise continue without one. - The PR author (human or agent) never reviews or approves its own PR. -- Merge gate: an Elsa 3 Code Review `APPROVE + HIGH @ ` (the full 40-character SHA of the PR's current head commit), plus green CI. Any push after the approval needs a re-confirm on the new head. -- Advisory reviews never replace the merge gate. +- Merge gate: the only merge gate is an Elsa 3 Code Review GitHub review on the PR whose body reads `APPROVE + HIGH @ ` (the full 40-character SHA of the PR's current head commit; posted as `sfmskywalker`, so its review state is COMMENTED, not APPROVED), plus green CI on that head. +- Pin the merge to the approved SHA: `gh pr merge --match-head-commit `, or the merge API (`PUT /repos/{owner}/{repo}/pulls/{n}/merge`) with `sha=`. Any push after the approval voids it; Code Review must re-confirm `APPROVE + HIGH @ ` before merging. +- Greptile, CodeRabbit, Copilot and Bugbot are advisory only. Their findings feed into the Code Review, but none of them is required for merge: there is no Greptile score gate (no 5/5 requirement) and no waive process. - Update this file whenever a reviewer is added, removed, or changes how it is requested. From 01a582dcdbeed93b75caeb7160965f50e4ed3e95 Mon Sep 17 00:00:00 2001 From: Sipke Schoorstra Date: Sun, 4 Oct 2026 14:16:26 +0200 Subject: [PATCH 2/3] docs(agents): drop Greptile waiver wording; point to the CR-only merge gate --- AGENTS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AGENTS.md b/AGENTS.md index 49b01e68..e1266560 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -1,3 +1,3 @@ # AGENTS.md -Before opening a PR, read `.github/reviewers.md` and request exactly one live advisory reviewer from it once the PR is open. Greptile is waived on this repository. +Before opening a PR, read `.github/reviewers.md` and request exactly one live advisory reviewer from it once the PR is open. Greptile does not review PRs here, and all automated reviewers are advisory; merge only on the gate described there (Elsa 3 Code Review `APPROVE + HIGH @ ` plus green CI, merge pinned to that SHA). From 2307c3f62c38b1fc14ed48f2ed4518d824f8f19d Mon Sep 17 00:00:00 2001 From: Sipke Schoorstra Date: Sun, 4 Oct 2026 14:42:15 +0200 Subject: [PATCH 3/3] docs(reviewers): spell out the exact Code Review header and verdict rules in the merge gate; bump Last verified --- .github/reviewers.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/reviewers.md b/.github/reviewers.md index 6825d289..bcf3c312 100644 --- a/.github/reviewers.md +++ b/.github/reviewers.md @@ -2,7 +2,7 @@ Live list of automated reviewers for this repository (elsa-extensions). Agents read it before opening a PR. -Last verified: 2026-10-03 +Last verified: 2026-10-04 | Reviewer | Status | How to request | Notes | | --- | --- | --- | --- | @@ -18,7 +18,7 @@ Last verified: 2026-10-03 - Pick exactly one live advisory reviewer from the table (currently Copilot) and request it once the PR is open. Do not request a second reviewer. - If the picked reviewer declines or skips the PR, request another live reviewer if there is one; otherwise continue without one. - The PR author (human or agent) never reviews or approves its own PR. -- Merge gate: the only merge gate is an Elsa 3 Code Review GitHub review on the PR whose body reads `APPROVE + HIGH @ ` (the full 40-character SHA of the PR's current head commit; posted as `sfmskywalker`, so its review state is COMMENTED, not APPROVED), plus green CI on that head. -- Pin the merge to the approved SHA: `gh pr merge --match-head-commit `, or the merge API (`PUT /repos/{owner}/{repo}/pulls/{n}/merge`) with `sha=`. Any push after the approval voids it; Code Review must re-confirm `APPROVE + HIGH @ ` before merging. +- Merge gate: the only merge gate is an Elsa 3 Code Review on the PR whose body starts with the line `Elsa 3 Code Review: APPROVE + HIGH @ ` (the full 40-character SHA of the PR's current head commit), plus green CI on that head. The Code Review is posted as `sfmskywalker` with review event COMMENT, so its GitHub review state is COMMENTED, not APPROVED. A `REQUEST_CHANGES` verdict, a confidence below `HIGH`, or a SHA other than the current head does not pass. The Code Review is a separate reviewer from the PR author, even when both post from the same account. +- Pin the merge to the approved SHA: `gh pr merge --match-head-commit `, or the merge API (`PUT /repos/{owner}/{repo}/pulls/{n}/merge`) with `sha=`. Any push after the approval voids it; Code Review must re-confirm with `Elsa 3 Code Review: APPROVE + HIGH @ ` before merging. - Greptile, CodeRabbit, Copilot and Bugbot are advisory only. Their findings feed into the Code Review, but none of them is required for merge: there is no Greptile score gate (no 5/5 requirement) and no waive process. - Update this file whenever a reviewer is added, removed, or changes how it is requested.