Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discussion] maintaining typescript-language-server as part of the organization #2147

Closed
yyoncho opened this issue Sep 6, 2020 · 6 comments

Comments

@yyoncho
Copy link
Member

yyoncho commented Sep 6, 2020

As many of you know https://github.com/theia-ide/typescript-language-server is no longer maintained. While it is stable and "just works" there is a new development on in tsserver which is not exposed through the server (e. g. call hierarchy). We had a discussion in gitter with @danielmartin so I decided to move it here to see if there are other people interested in working on this.

I think that the overall complexity of typescript-language-server is not high because it is proxy so for someone familiar with js/ts won't be hard to keep up with tsserver features.

@danielmartin
Copy link
Contributor

What's the status of https://github.com/sourcegraph/javascript-typescript-langserver? Has anyone tried this language server recently? It seems more actively developed as there's a company behind it, Sourcegraph.

If we decide that Theia is the best one, I agree about maintaining our own fork under the emacs-lsp organization. We'll need to advertise it well so that TypeScript developers that use Emacs, Vim, Sublime... can contribute to it. We can use JS/TypeScript Reddits and Twitter.

@jcs090218
Copy link
Member

What's the status of https://github.com/sourcegraph/javascript-typescript-langserver? Has anyone tried this language server recently? It seems more actively developed as there's a company behind it, Sourcegraph.

I have just tried this language server today. I think it is pretty decent, and mainly stable. Yet quick glance from the GitHub page; there are multiple issues not discussed.

If we decide that Theia is the best one, I agree about maintaining our own fork under the emacs-lsp organization. We'll need to advertise it well so that TypeScript developers that use Emacs, Vim, Sublime... can contribute to it. We can use JS/TypeScript Reddits and Twitter.

That's sounds about right! This issue most likely going to be across any other editors that use this language server.

@leungbk
Copy link
Member

leungbk commented Sep 6, 2020

What's the status of https://github.com/sourcegraph/javascript-typescript-langserver? Has anyone tried this language server recently?

I encountered memory leaks when I tried the Sourcegraph server a few months ago. The Theia server generally works well for me.

It seems more actively developed as there's a company behind it, Sourcegraph.

It's not actively developed at all. Almost every commit from the last two years has been from dependabot.

@jcs090218
Copy link
Member

I think the related discussion is here. neovim/nvim-lspconfig#250

@leungbk
Copy link
Member

leungbk commented Sep 26, 2020

The TypeScript team is slowly re-working tsserver to comply with LSP: microsoft/TypeScript#39459 (comment)

So I'm not sure if we need to worry about maintaining Theia's server anymore. In its present state, it still works well-ish for routine tasks, and anyone who needs better tsserver integration in the short term can always use tide until tsserver transitions fully to LSP.

@yyoncho
Copy link
Member Author

yyoncho commented Sep 26, 2020

@leungbk thank you. Closing the issue, if tsserver is going to support lsp there is no point to invest time in Theia server.

@yyoncho yyoncho closed this as completed Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants