Skip to content

Commit 2b3763e

Browse files
committed
Merge from origin/emacs-30
d3c39fb Fix display of keys in 'help-form' buffers (bug#77118) 6509cc2 Improve documentation of 'user-emacs-directory' 3f06059 Update remarks on name prefixes in coding conventions e966ff9 ; * doc/emacs/files.texi (Image Mode): Fix a typo (bug#77... 378bea9 ; Fix doc strings of a few Dired commands 30fb2ac ; * CONTRIBUTE: Clarify single-line commit should end wit... 417d14a ; * admin/MAINTAINERS: Complete the handover of VC bb756b1 ; Fix typo in Tramp
2 parents 6221e9a + d3c39fb commit 2b3763e

File tree

7 files changed

+47
-34
lines changed

7 files changed

+47
-34
lines changed

CONTRIBUTE

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,8 @@ formatting them:
241241
there will be no individual ChangeLog entries beyond the one in the
242242
summary line.
243243

244+
- If the commit message is a single-line, it should end with a period.
245+
244246
- If the commit has more than one author, the commit message should
245247
contain separate lines to mention the other authors, like the
246248
following:

admin/MAINTAINERS

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -245,9 +245,6 @@ Sean Whitton
245245
==============================================================================
246246
2. Areas that someone is willing to maintain, although he would not
247247
necessarily mind if someone else was the official maintainer.
248-
This list also includes people who are in the process of handing over
249-
maintainership to someone listed above, but who want to continue to be
250-
CC'd as though they were still the primary maintainer, in the meantime.
251248
==============================================================================
252249

253250
Eli Zaretskii
@@ -342,7 +339,6 @@ Tassilo Horn
342339

343340
Dmitry Gutov
344341
lisp/whitespace.el
345-
lisp/vc/*
346342

347343
Vibhav Pant
348344
lisp/net/browse-url.el

doc/emacs/custom.texi

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2965,9 +2965,19 @@ Emacs will set @code{user-emacs-directory} to the directory it decides
29652965
to use. This directory is subsequently used to look for your other
29662966
user-specific Emacs files, such as @code{custom-file} (@pxref{Saving
29672967
Customizations}), the saved desktop (@pxref{Saving Emacs Sessions}) and
2968-
others. The @code{--init-directory} command-line option (@pxref{Initial
2969-
Options}) overrides the value of @code{user-emacs-directory} determined
2970-
as side effect of the search for your user init file described above.
2968+
others. It is also used to compute the value of the
2969+
@code{native-comp-eln-load-path} (@pxref{Lisp Libraries}), which is
2970+
where Emacs looks for natively-compiled Lisp code and where it deposits
2971+
the newly-compiled Lisp code produced by asynchronous compilation of
2972+
packages your init files and the subsequent Emacs session load. The
2973+
@code{--init-directory} command-line option (@pxref{Initial Options})
2974+
overrides the value of @code{user-emacs-directory} determined as side
2975+
effect of the search for your user init file described above.
2976+
2977+
Since @code{user-emacs-directory}, once determined by Emacs, is used by
2978+
the rest of the startup code to locate other files and directories, we
2979+
do not recommend changing its value in your init files, as that could
2980+
disrupt or break the correct startup of your Emacs sessions.
29712981

29722982
Although this is backward-compatible with older Emacs versions, modern
29732983
POSIX platforms prefer putting your initialization files under

doc/emacs/files.texi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2529,7 +2529,7 @@ select a group of images to copy somewhere else). The @kbd{m}
25292529
(@code{image-mode-mark-file}) command will mark the current file in
25302530
any Dired buffer(s) that display the current file's directory. If no
25312531
such buffer is open, the directory is opened in a new buffer. To
2532-
unmark files, use the @kbd{u} (@code{image-mode-mark-file}) command.
2532+
unmark files, use the @kbd{u} (@code{image-mode-unmark-file}) command.
25332533
Finally, if you just want to copy the current buffers file name to the
25342534
kill ring, you can use the @kbd{w}
25352535
(@code{image-mode-copy-file-name-as-kill}) command.

doc/lispref/tips.texi

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -73,18 +73,13 @@ not meant to be used by other packages.
7373
Occasionally, for a command name intended for users to use, it is more
7474
convenient if some words come before the package's name prefix. For
7575
example, it is our convention to have commands that list objects named
76-
as @samp{list-@var{something}}, e.g., a package called @samp{frob}
77-
could have a command @samp{list-frobs}, when its other global symbols
78-
begin with @samp{frob-}. Also, constructs that define functions,
79-
variables, etc., work better if they start with @samp{define-}, so put
80-
the name prefix later on in the name.
81-
82-
This recommendation applies even to names for traditional Lisp
83-
primitives that are not primitives in Emacs Lisp---such as
84-
@code{copy-list}. Believe it or not, there is more than one plausible
85-
way to define @code{copy-list}. Play it safe; append your name prefix
86-
to produce a name like @code{foo-copy-list} or @code{mylib-copy-list}
87-
instead.
76+
as @samp{list-@var{something}}, e.g., a package called @samp{frob} could
77+
have a command @samp{list-frobs}, when its other global symbols begin
78+
with @samp{frob-}. Also, constructs that define functions, variables,
79+
etc., may work better if they start with @samp{define-}, so it's okay to
80+
put the name prefix later on in the name. Outside of these
81+
well-established cases, however, err on the side of prepending your name
82+
prefix.
8883

8984
If you write a function that you think ought to be added to Emacs under
9085
a certain name, such as @code{twiddle-files}, don't call it by that name

lisp/dired-aux.el

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -490,9 +490,11 @@ List has a form of (file-name full-file-name (attribute-list))."
490490
(defun dired-do-chmod (&optional arg)
491491
"Change the mode of the marked (or next ARG) files.
492492
Both octal numeric modes like `644' and symbolic modes like `g+w'
493-
are supported. Type \\<minibuffer-local-completion-map>\
494-
\\[next-history-element] to pull the file attributes of the file
495-
at point into the minibuffer.
493+
are supported.
494+
After invoking the command, \
495+
type \\<minibuffer-local-completion-map>\\[next-history-element] \
496+
to pull the file attributes
497+
of the file at point into the minibuffer.
496498
497499
See Info node `(coreutils)File permissions' for more information.
498500
Alternatively, see the man page for \"chmod(1)\".
@@ -541,9 +543,10 @@ has no effect on MS-Windows."
541543
;;;###autoload
542544
(defun dired-do-chgrp (&optional arg)
543545
"Change the group of the marked (or next ARG) files.
544-
Type \\<minibuffer-local-completion-map>\\[next-history-element] \
545-
to pull the file attributes of the file at point
546-
into the minibuffer."
546+
After invoking the command, \
547+
type \\<minibuffer-local-completion-map>\\[next-history-element] \
548+
to pull the file attributes
549+
of the file at point into the minibuffer."
547550
(interactive "P" dired-mode)
548551
(if (and (memq system-type '(ms-dos windows-nt))
549552
(not (file-remote-p default-directory)))
@@ -553,9 +556,10 @@ into the minibuffer."
553556
;;;###autoload
554557
(defun dired-do-chown (&optional arg)
555558
"Change the owner of the marked (or next ARG) files.
556-
Type \\<minibuffer-local-completion-map>\\[next-history-element] \
557-
to pull the file attributes of the file at point
558-
into the minibuffer."
559+
After invoking the command, \
560+
type \\<minibuffer-local-completion-map>\\[next-history-element] \
561+
to pull the file attributes
562+
of the file at point into the minibuffer."
559563
(interactive "P" dired-mode)
560564
(if (and (memq system-type '(ms-dos windows-nt))
561565
(not (file-remote-p default-directory)))
@@ -566,9 +570,10 @@ into the minibuffer."
566570
(defun dired-do-touch (&optional arg)
567571
"Change the timestamp of the marked (or next ARG) files.
568572
This calls touch.
569-
Type Type \\<minibuffer-local-completion-map>\\[next-history-element] \
570-
to pull the file attributes of the file at point
571-
into the minibuffer."
573+
After invoking the command, \
574+
type \\<minibuffer-local-completion-map>\\[next-history-element] \
575+
to pull the file attributes
576+
of the file at point into the minibuffer."
572577
(interactive "P" dired-mode)
573578
(dired-do-chxxx "Timestamp" dired-touch-program 'touch arg))
574579

lisp/help.el

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2190,8 +2190,13 @@ The `temp-buffer-window-setup-hook' hook is called."
21902190
"Display the output of a non-nil `help-form'."
21912191
(let ((msg (eval help-form t)))
21922192
(if (stringp msg)
2193-
(with-output-to-temp-buffer " *Char Help*"
2194-
(princ msg)))))
2193+
(let ((bufname " *Char Help*"))
2194+
(with-output-to-temp-buffer bufname)
2195+
;; Use `insert' instead of `princ' so that keys in `help-form'
2196+
;; are displayed with `help-key-binding' face (bug#77118).
2197+
(with-current-buffer bufname
2198+
(let (buffer-read-only)
2199+
(insert msg)))))))
21952200

21962201
(defun help--append-keystrokes-help (str)
21972202
(let* ((keys (this-single-command-keys))

0 commit comments

Comments
 (0)