Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_getTestFramework is checking for incorrect mocha package #471

Open
andrewfan opened this issue Jan 9, 2020 · 2 comments
Open

_getTestFramework is checking for incorrect mocha package #471

andrewfan opened this issue Jan 9, 2020 · 2 comments

Comments

@andrewfan
Copy link

ember-cli-mocha package is deprecated thus here https://github.com/ember-cli/ember-exam/blob/master/lib/commands/exam.js#L136 we should also check for ember-mocha dependency
@choheekim choheekim mentioned this issue Jan 9, 2020
Merged
@choheekim
Copy link
Collaborator

looking into it!
#472

@step2yeung
Copy link
Collaborator

@andrewfan looks like #472 is merged! Have you had a chance to verify this is good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewfan @step2yeung @choheekim