Skip to content

Route-specific components end up severely over-nested #39

@chriskrycho

Description

@chriskrycho

We have a couple components that are only used on specific routes. It appears (I haven't dug into the migrator internals yet) that the intent is for route-specific components to live as children of the relevant routes. This makes good sense. However, the migrator (and perhaps the proposed pattern? Not sure) currently seems a bit... enthusiastic about the nesting (this is all under src/ui/routes):

nesting

It seems like the actual structure converted structure here should be something like this instead:

routes/
  checkout/
    place-order/
      -components/
        order-submission/
          olo-payment/
            olo-billing-scheme/
          create-card/

Obviously these can (and in several cases would) simply be moved to the general src/ui/components directory. My concern is just about all the extra checkout nesting.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions