Updated ember-source to v4.4.2 (#108)

ijlee2 · web-flow · commit 3aa249694420 · 2022-06-17T07:23:39.000+02:00
* chore: Updated development dependencies to their latest version

* chore: Fixed linting errors

* chore: Updated eslint to v8

* chore: Updated ember-source to v4.4.2

* refactor: Imported service directly from @ember/service

Co-authored-by: ijlee2 &lt;ijlee2@users.noreply.github.com&gt;
diff --git a/.ember-cli b/.ember-cli
@@ -5,5 +5,11 @@
 
     Setting `disableAnalytics` to true will prevent any data from being sent.
   */
-  "disableAnalytics": false
+  "disableAnalytics": false,
+
+  /**
+  Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
+  rather than JavaScript by default, when a TypeScript version of a given blueprint is available.
+  */
+  "isTypeScriptProject": false
 }
diff --git a/.eslintignore b/.eslintignore
@@ -19,7 +19,10 @@
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
+/package-lock.json.ember-try
+/yarn.lock.ember-try
 
 # Ignore code examples for the cheat sheet
 /snippets/
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -2,12 +2,15 @@
 
 module.exports = {
   root: true,
-  parser: 'babel-eslint',
+  parser: '@babel/eslint-parser',
   parserOptions: {
     ecmaVersion: 2018,
     sourceType: 'module',
-    ecmaFeatures: {
-      legacyDecorators: true,
+    requireConfigFile: false,
+    babelOptions: {
+      plugins: [
+        ['@babel/plugin-proposal-decorators', { decoratorsBeforeExport: true }],
+      ],
     },
   },
   plugins: ['ember'],
@@ -50,7 +53,7 @@ module.exports = {
       },
     },
     {
-      // Test files:
+      // test files
       files: ['tests/**/*-test.{js,ts}'],
       extends: ['plugin:qunit/recommended'],
       rules: {
diff --git a/.gitignore b/.gitignore
@@ -23,4 +23,10 @@
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
+/package-lock.json.ember-try
+/yarn.lock.ember-try
+
+# broccoli-debug
+/DEBUG/
diff --git a/.prettierignore b/.prettierignore
@@ -14,11 +14,15 @@
 /coverage/
 !.*
 .eslintcache
+.lint-todo/
 
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
+/package-lock.json.ember-try
+/yarn.lock.ember-try
 
 # Ignore code examples for the cheat sheet
 /snippets/
diff --git a/app/components/guide-section/subsection.js b/app/components/guide-section/subsection.js
@@ -1,5 +1,5 @@
 import Component from '@glimmer/component';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 
 export default class GuideSectionSubsectionComponent extends Component {
   @service intl;
diff --git a/app/components/locale-menu.js b/app/components/locale-menu.js
@@ -1,5 +1,5 @@
 import { action } from '@ember/object';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 import Component from '@glimmer/component';
 
 export default class LocaleMenuComponent extends Component {
diff --git a/app/services/locale.js b/app/services/locale.js
@@ -1,4 +1,4 @@
-import Service, { inject as service } from '@ember/service';
+import Service, { service } from '@ember/service';
 
 /*
   To help with maintainenance, please list
diff --git a/app/templates/application.hbs b/app/templates/application.hbs
@@ -1,4 +1,4 @@
-{{page-title "Ember.js Octane vs Classic Cheat Sheet"}}
+{{page-title (t "layout.application.title")}}
 
 <header local-class="header">
   <img
diff --git a/config/dependency-lint.js b/config/dependency-lint.js
@@ -1,7 +1,5 @@
 'use strict';
 
 module.exports = {
-  allowedVersions: {
-    '@ember/test-waiters': '3.0.0 || 2.4.3',
-  },
+  allowedVersions: {},
 };
diff --git a/config/ember-cli-update.json b/config/ember-cli-update.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "name": "ember-cli",
-      "version": "3.28.4",
+      "version": "4.4.0",
       "blueprints": [
         {
           "name": "app",
diff --git a/config/environment.js b/config/environment.js
@@ -5,7 +5,7 @@ module.exports = function (environment) {
     modulePrefix: 'ember-octane-vs-classic-cheat-sheet',
     environment,
     rootURL: '/',
-    locationType: 'auto',
+    locationType: 'history',
     EmberENV: {
       FEATURES: {
         // Here you can enable experimental features on an ember canary build
diff --git a/config/targets.js b/config/targets.js
@@ -6,21 +6,6 @@ const browsers = [
   'last 1 Safari versions',
 ];
 
-// Ember's browser support policy is changing, and IE11 support will end in
-// v4.0 onwards.
-//
-// See https://deprecations.emberjs.com/v3.x#toc_3-0-browser-support-policy
-//
-// If you need IE11 support on a version of Ember that still offers support
-// for it, uncomment the code block below.
-//
-// const isCI = Boolean(process.env.CI);
-// const isProduction = process.env.EMBER_ENV === 'production';
-//
-// if (isCI || isProduction) {
-//   browsers.push('ie 11');
-// }
-
 module.exports = {
   browsers,
   node: 'current',
diff --git a/package.json b/package.json
@@ -27,57 +27,57 @@
     "test": "ember test"
   },
   "devDependencies": {
+    "@babel/eslint-parser": "^7.18.2",
+    "@babel/plugin-proposal-decorators": "^7.18.2",
     "@ember/optional-features": "^2.0.0",
-    "@ember/test-helpers": "^2.6.0",
-    "@glimmer/component": "^1.0.4",
-    "@glimmer/tracking": "^1.0.4",
-    "@percy/cli": "^1.0.0-beta.71",
+    "@ember/test-helpers": "^2.8.1",
+    "@glimmer/component": "^1.1.2",
+    "@glimmer/tracking": "^1.1.2",
+    "@percy/cli": "^1.3.1",
     "@percy/ember": "^3.0.0",
-    "babel-eslint": "^10.1.0",
     "broccoli-asset-rev": "^3.0.0",
-    "ember-a11y-testing": "^4.3.0",
-    "ember-auto-import": "^2.2.4",
-    "ember-cli": "~3.28.4",
+    "ember-a11y-testing": "^5.0.0",
+    "ember-auto-import": "^2.4.2",
+    "ember-cli": "~4.4.0",
     "ember-cli-app-version": "^5.0.0",
-    "ember-cli-babel": "^7.26.6",
-    "ember-cli-dependency-checker": "^3.2.0",
+    "ember-cli-babel": "^7.26.11",
+    "ember-cli-dependency-checker": "^3.3.1",
     "ember-cli-dependency-lint": "^2.0.1",
     "ember-cli-deploy": "^1.0.2",
     "ember-cli-deploy-build": "^2.0.0",
     "ember-cli-deploy-git": "^1.3.4",
-    "ember-cli-fastboot": "^2.2.1",
+    "ember-cli-fastboot": "^3.3.1",
     "ember-cli-htmlbars": "^6.0.1",
     "ember-cli-inject-live-reload": "^2.1.0",
     "ember-cli-sri": "^2.1.1",
     "ember-cli-terser": "^4.0.2",
     "ember-code-snippet": "^3.0.0",
-    "ember-container-query": "^2.0.0-alpha.0",
-    "ember-css-modules": "^2.0.0",
+    "ember-container-query": "^2.1.0",
+    "ember-css-modules": "^2.0.1",
     "ember-export-application-global": "^2.0.1",
     "ember-fetch": "^8.1.1",
-    "ember-intl": "^5.7.0",
+    "ember-intl": "^5.7.2",
     "ember-load-initializers": "^2.1.2",
-    "ember-maybe-import-regenerator": "^1.0.0",
     "ember-page-title": "^7.0.0",
     "ember-prism": "^0.12.0",
     "ember-qunit": "^5.1.5",
     "ember-resolver": "^8.0.3",
-    "ember-source": "~3.28.8",
-    "ember-template-lint": "^3.14.0",
+    "ember-source": "~4.4.0",
+    "ember-template-lint": "^4.10.0",
     "ember-test-selectors": "^6.0.0",
-    "eslint": "^7.32.0",
-    "eslint-config-prettier": "^8.3.0",
-    "eslint-plugin-ember": "^10.5.8",
+    "eslint": "^8.17.0",
+    "eslint-config-prettier": "^8.5.0",
+    "eslint-plugin-ember": "^10.6.1",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-prettier": "^4.0.0",
-    "eslint-plugin-qunit": "^7.1.0",
+    "eslint-plugin-qunit": "^7.3.0",
     "loader.js": "^4.7.0",
     "npm-run-all": "^4.1.5",
-    "prember": "^1.0.5",
-    "prettier": "^2.5.1",
-    "qunit": "^2.17.2",
+    "prember": "^1.1.0",
+    "prettier": "^2.7.1",
+    "qunit": "^2.19.1",
     "qunit-dom": "^2.0.0",
-    "webpack": "^5.65.0"
+    "webpack": "^5.73.0"
   },
   "engines": {
     "node": "12.* || 14.* || >= 16"
diff --git a/tests/helpers/.gitkeep b/tests/helpers/.gitkeep
diff --git a/tests/helpers/index.js b/tests/helpers/index.js
@@ -0,0 +1,42 @@
+import {
+  setupApplicationTest as upstreamSetupApplicationTest,
+  setupRenderingTest as upstreamSetupRenderingTest,
+  setupTest as upstreamSetupTest,
+} from 'ember-qunit';
+
+// This file exists to provide wrappers around ember-qunit's / ember-mocha's
+// test setup functions. This way, you can easily extend the setup that is
+// needed per test type.
+
+function setupApplicationTest(hooks, options) {
+  upstreamSetupApplicationTest(hooks, options);
+
+  // Additional setup for application tests can be done here.
+  //
+  // For example, if you need an authenticated session for each
+  // application test, you could do:
+  //
+  // hooks.beforeEach(async function () {
+  //   await authenticateSession(); // ember-simple-auth
+  // });
+  //
+  // This is also a good place to call test setup functions coming
+  // from other addons:
+  //
+  // setupIntl(hooks); // ember-intl
+  // setupMirage(hooks); // ember-cli-mirage
+}
+
+function setupRenderingTest(hooks, options) {
+  upstreamSetupRenderingTest(hooks, options);
+
+  // Additional setup for rendering tests can be done here.
+}
+
+function setupTest(hooks, options) {
+  upstreamSetupTest(hooks, options);
+
+  // Additional setup for unit tests can be done here.
+}
+
+export { setupApplicationTest, setupRenderingTest, setupTest };
diff --git a/tests/index.html b/tests/index.html
@@ -2,7 +2,6 @@
 <html lang="en">
   <head>
     <meta charset="utf-8">
-    <meta http-equiv="X-UA-Compatible" content="IE=edge">
     <title>Ember.js Octane vs Classic Cheat Sheet Tests</title>
     <meta name="description" content="See side-by-side examples of Ember Octane and Ember Classic">
     <meta name="viewport" content="width=device-width, initial-scale=1">
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import Service, { inject as service } from '@ember/service';`
	`1`	`+import Service, { service } from '@ember/service';`
`2`	`2`
`3`	`3`	`/*`
`4`	`4`	`To help with maintainenance, please list`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-{{page-title "Ember.js Octane vs Classic Cheat Sheet"}}`
	`1`	`+{{page-title (t "layout.application.title")}}`
`2`	`2`
`3`	`3`	`<header local-class="header">`
`4`	`4`	`<img`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`"packages": [`
`4`	`4`	`{`
`5`	`5`	`"name": "ember-cli",`
`6`		`- "version": "3.28.4",`
	`6`	`+ "version": "4.4.0",`
`7`	`7`	`"blueprints": [`
`8`	`8`	`{`
`9`	`9`	`"name": "app",`