Update ember-source to v3.25 (#81)

* Updated development dependencies to their latest version

* Addressed an accessibility issue (missing label)

* Updated ember-source to v3.25.4

* Specified which files to lint

* Ran Prettier

* Updated linting instructions

Co-authored-by: Isaac Lee <[email protected]>

Author: ijlee2

.eslintignore

@@ -13,8 +13,12 @@
 # misc
 /coverage/
 !.*
+.eslintcache
 
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
 /package.json.ember-try
+
+# Ignore code examples for the cheat sheet
+/snippets/

.eslintrc.js

@@ -7,47 +7,47 @@ module.exports = {
     ecmaVersion: 2018,
     sourceType: 'module',
     ecmaFeatures: {
-      legacyDecorators: true
-    }
+      legacyDecorators: true,
+    },
   },
-  plugins: [
-    'ember'
-  ],
+  plugins: ['ember'],
   extends: [
     'eslint:recommended',
-    'plugin:ember/recommended'
+    'plugin:ember/recommended',
+    'plugin:prettier/recommended',
   ],
   env: {
-    browser: true
+    browser: true,
   },
   rules: {},
   overrides: [
     // node files
     {
       files: [
         '.eslintrc.js',
+        '.prettierrc.js',
         '.template-lintrc.js',
         'ember-cli-build.js',
         'testem.js',
         'blueprints/*/index.js',
         'config/**/*.js',
         'lib/*/index.js',
-        'server/**/*.js'
+        'server/**/*.js',
       ],
       parserOptions: {
-        sourceType: 'script'
+        sourceType: 'script',
       },
       env: {
         browser: false,
-        node: true
+        node: true,
       },
       plugins: ['node'],
       extends: ['plugin:node/recommended'],
       rules: {
         // this can be removed once the following is fixed
         // https://github.com/mysticatea/eslint-plugin-node/issues/77
-        'node/no-unpublished-require': 'off'
-      }
-    }
-  ]
+        'node/no-unpublished-require': 'off',
+      },
+    },
+  ],
 };

.gitignore

@@ -12,6 +12,7 @@
 /.env*
 /.pnp*
 /.sass-cache
+/.eslintcache
 /connect.lock
 /coverage/
 /libpeerconnection.log

.prettierignore

@@ -0,0 +1,24 @@
+# unconventional js
+/blueprints/*/files/
+/vendor/
+
+# compiled output
+/dist/
+/tmp/
+
+# dependencies
+/bower_components/
+/node_modules/
+
+# misc
+/coverage/
+!.*
+.eslintcache
+
+# ember-try
+/.node_modules.ember-try/
+/bower.json.ember-try
+/package.json.ember-try
+
+# Ignore code examples for the cheat sheet
+/snippets/

.prettierrc.js

@@ -0,0 +1,5 @@
+'use strict';
+
+module.exports = {
+  singleQuote: true,
+};

.template-lintrc.js

@@ -3,6 +3,6 @@
 module.exports = {
   extends: 'octane',
   rules: {
-    'no-bare-strings': true
-  }
+    'no-bare-strings': true,
+  },
 };

README.md

@@ -24,6 +24,12 @@ yarn lint
 yarn test
 ```
 
+To fix linting errors, try the following command:
+
+```bash
+yarn lint:fix
+```
+
 
 ## Continuous deployment
 

app/components/locale-menu/template.hbs

@@ -1,10 +1,15 @@
+<label for="locale-menu">
+  {{t "component.locale-menu.locale-select.label"}}
+</label>
+
 <select
   class="locale-menu"
   data-test-field="Locale"
+  id="locale-menu"
   {{on "input" this.updateLocale}}
 >
   <option value="" disabled selected>
-   {{t "component.locale-menu.select-your-preferred-language"}}
+   {{t "component.locale-menu.locale-select.placeholder"}}
   </option>
 
   {{#each this.locale.menuOptions as |menuOption|}}

app/controllers/application.js

@@ -3,4 +3,4 @@ import config from 'ember-octane-vs-classic-cheat-sheet/config/environment';
 
 export default class ApplicationController extends Controller {
   rootURL = config.rootURL.replace(/\/$/, '');
-}
+}

app/formats.js

@@ -3,28 +3,28 @@ export default {
     hhmmss: {
       hour: 'numeric',
       minute: 'numeric',
-      second: 'numeric'
-    }
+      second: 'numeric',
+    },
   },
   date: {
     hhmmss: {
       hour: 'numeric',
       minute: 'numeric',
-      second: 'numeric'
-    }
+      second: 'numeric',
+    },
   },
   number: {
     EUR: {
       style: 'currency',
       currency: 'EUR',
       minimumFractionDigits: 2,
-      maximumFractionDigits: 2
+      maximumFractionDigits: 2,
     },
     USD: {
       style: 'currency',
       currency: 'USD',
       minimumFractionDigits: 2,
-      maximumFractionDigits: 2
-    }
-  }
+      maximumFractionDigits: 2,
+    },
+  },
 };

app/helpers/get-prism-language.js

@@ -2,16 +2,18 @@ import { helper } from '@ember/component/helper';
 
 const mapLangugage = {
   shell: 'bash',
-  text: 'markup'
+  text: 'markup',
 };
 
 // Convert the Ember Code Snippet language if needed
 export default helper(function getPrismLanguage(params) {
   const emberCodeSnippetLanguage = params[0];
 
-  if (Object.prototype.hasOwnProperty.call(mapLangugage, emberCodeSnippetLanguage)) {
+  if (
+    Object.prototype.hasOwnProperty.call(mapLangugage, emberCodeSnippetLanguage)
+  ) {
     return mapLangugage[emberCodeSnippetLanguage];
   }
 
   return emberCodeSnippetLanguage;
-});
+});

app/index.html

@@ -3,7 +3,6 @@
   <head>
     <meta charset="utf-8">
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
-    <title>Ember.js Octane vs Classic Cheat Sheet</title>
     <meta name="description" content="See side-by-side examples of Ember Octane and Ember Classic">
     <meta name="viewport" content="width=device-width, initial-scale=1">
 

app/router.js

@@ -6,5 +6,4 @@ export default class Router extends EmberRouter {
   rootURL = config.rootURL;
 }
 
-Router.map(function() {
-});
+Router.map(function () {});