Merge pull request #295 from ember-learn/footer-issues

Implement the new design for the Footer

Author: MelSumner

addon/styles/components/es-footer.css

@@ -20,11 +20,19 @@
   }
 
   & .footer-info {
+    padding-bottom: var(--spacing-5);
+    padding-top: var(--spacing-5);
     display: flex;
     justify-content: space-between;
 
-    & .logo-wrapper {
-      grid-row: 1 / 4;
+    & .spacer {
+      grid-row: 2 / 4;
+    }
+
+    & .info-link {
+      margin-top: auto;
+      margin-bottom: auto;
+      line-height: 40px;
     }
   }
 
@@ -58,22 +66,28 @@
 
   & .footer-statement {
     justify-content: space-between;
-    background-color: var(--color-gray-100);
   }
 
   & .footer-copyright {
     color: var(--color-gray-600);
   }
 
-  & .footer-contributions-wrapper {
-    background-color: var(--color-white);
+  & .footer-spacer {
+    border: 0;
+    border-top: 2px solid var(--color-gray-300);
+    display: block;
+    height: 2px;
   }
 
   & .footer-contributions {
     align-items: center;
     color: var(--color-gray-600);
     display: flex;
     justify-content: space-between;
+
+    & .sponsor-icons {
+      margin-top: var(--spacing-1);
+    }
   }
 
   & .footer-contributor-logo,
@@ -85,30 +99,31 @@
 
   @media (max-width: 1007px) {
     & .footer-info {
+      padding-bottom: var(--spacing-3);
+      padding-top: var(--spacing-3);
       flex-direction: column;
 
       & .footer-logo {
-        margin-bottom: var(--spacing-1);
         width: 5rem;
       }
     }
 
     & .footer-info-links {
-      display: flex;
+      display: block;
       flex-wrap: wrap;
 
       & > a {
         margin-right: var(--spacing-2);
       }
-
-      & .logo-wrapper {
-        width: 100%;
-      }
     }
 
     & .footer-contributions {
       align-items: start;
       flex-direction: column;
+
+      & .sponsor-icons {
+        margin-top: var(--spacing-2);
+      }
     }
   }
 }

addon/templates/components/es-footer.hbs

@@ -7,5 +7,7 @@
 
   <EsFooter::EsStatement @tagline={{tagline}} />
 
+  <hr class="footer-spacer container py-0 my-3">
+
   <EsFooter::EsContributions @contributorLinks={{contributorLinks}} />
 </footer>

addon/templates/components/es-footer/es-contributions.hbs

@@ -1,7 +1,7 @@
-<div class="footer-contributions-wrapper container py-3">
+<div class="footer-contributions-wrapper container pt-0 pb-3">
   <div class="footer-contributions">
     <span>Ember is generously supported by</span>
-    <div class="mt-1">
+    <div class="sponsor-icons">
       {{#each args.contributorLinks as |link|}}
         <a href={{link.href}} title={{link.title}} aria-label={{link.title}} class="mr-2">
           {{svg-jar link.class class="footer-contributor-logo"}}

addon/templates/components/es-footer/es-info.hbs

@@ -1,10 +1,12 @@
-<div class="footer-info container py-2 text-sm">
+<div class="footer-info container">
   <div class="footer-info-links">
-    <div class="logo-wrapper">
-      <img src="/images/ember-logo.svg" alt="Ember Logo" class="footer-logo">
-    </div>
+
+    <img src="/images/ember-logo.svg" height="40px" width="83px" alt="Ember Logo" class="footer-logo">
+
+    <div class="spacer"></div>
+
     {{#each args.infoLinks as |link|}}
-      <a href={{link.href}}>{{link.name}}</a>
+      <a href={{link.href}} class="info-link">{{link.name}}</a>
     {{/each}}
   </div>
   <div class="footer-social hide-on-mobile">

addon/templates/components/es-footer/es-statement.hbs

@@ -1,5 +1,5 @@
 <div class="footer-statement">
-  <p class="footer-copyright container py-3">
+  <p class="footer-copyright container py-1">
     &copy; Copyright {{currentYear}} - <a href="https://www.tilde.io/" class="footer-copyright">Tilde Inc.</a>
     <br>
     {{args.tagline}}