Skip to content

Commit 8de8851

Browse files
Fix invalid setting type (#410)
1 parent bef0bff commit 8de8851

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

lib/inputstreamhelper/kodiutils.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -193,14 +193,11 @@ def get_setting_int(key, default=None):
193193

194194
def get_setting_float(key, default=None):
195195
"""Get an add-on setting as float"""
196+
value = get_setting(key, default)
196197
try:
197-
return ADDON.getSettingNumber(key)
198-
except (AttributeError, TypeError): # On Krypton or older, or when not a float
199-
value = get_setting(key, default)
200-
try:
201-
return float(value)
202-
except ValueError:
203-
return default
198+
return float(value)
199+
except ValueError:
200+
return default
204201
except RuntimeError: # Occurs when the add-on is disabled
205202
return default
206203

resources/settings.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<settings>
3-
<setting id="last_modified" value="0.0" visible="false"/>
4-
<setting id="last_check" value="0.0" visible="false"/>
5-
<setting id="version" value="" visible="false"/>
63
<category label="30900"> <!-- Expert -->
4+
<setting id="last_modified" default="0.0" visible="false"/>
5+
<setting id="last_check" default="0.0" visible="false"/>
6+
<setting id="version" default="" visible="false"/>
77
<setting label="30901" help="30902" type="action" action="RunScript(script.module.inputstreamhelper, info)"/>
88
<setting type="sep"/>
99
<setting label="30903" help="30904" type="bool" id="disabled" default="false"/>

0 commit comments

Comments
 (0)