Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Cache Key for Mapping #5714

Open
sekar-saravanan opened this issue Jul 3, 2024 · 1 comment
Open

Incorrect Cache Key for Mapping #5714

sekar-saravanan opened this issue Jul 3, 2024 · 1 comment
Labels
t:bug Something isn't working

Comments

@sekar-saravanan
Copy link
Contributor

Describe the bug
_cache_key is getting generated incorrectly for mappings in ir.json, when using header with regex.

Steps to reproduce the behavior:
Create mapping with regex header (attached mapping.yaml)
Fetch ir.json generated by emissary (attached sample ir.json)
Check the _cache_key of the mappings inside the groups block.
Always _cache_key should be in the format of {kind}-{version}-{name}-{namespace}. But header_name is getting updated in the place of mapping name

Imapct
If we plan to use the _cache_key in any feature ticket, it could get impacted.

Expected behavior
Always _cache_key should be in defined format. {kind}-{version}-{name}-{namespace}

Versions (please complete the following information):

  • Ambassador: 3.9.1
  • Kubernetes environment: EKS
  • Version: 1.28.9

Additional context
Attached the mapping.yaml and ir.json files.
incorrect-cache-key.zip

@dosubot dosubot bot added the t:bug Something isn't working label Jul 3, 2024
@sekar-saravanan
Copy link
Contributor Author

Fix added for this issue: https://github.com/emissary-ingress/emissary/pull/5715/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant