Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(webhook): add 'disconnected_at', 'node' fields in callback #214

Merged
merged 2 commits into from
Oct 10, 2020
Merged

feature(webhook): add 'disconnected_at', 'node' fields in callback #214

merged 2 commits into from
Oct 10, 2020

Conversation

wwhai
Copy link
Contributor

@wwhai wwhai commented Oct 9, 2020

No description provided.

@wwhai wwhai added the feature label Oct 9, 2020
@wwhai wwhai added this to the 4.2.0 milestone Oct 9, 2020
@wwhai wwhai linked an issue Oct 9, 2020 that may be closed by this pull request
Can the disconnection time include the disconnection time? #125
Open
@wwhai wwhai changed the title feature(webhook): add 'disconnect_at', 'node' fields in callback feature(webhook): add 'disconnected_at', 'node' fields in callback Oct 9, 2020
HJianBo
HJianBo suggested changes Oct 10, 2020
View reviewed changes
test/emqx_web_hook_SUITE.erl Outdated Show resolved Hide resolved
@HJianBo HJianBo modified the milestones: 4.2.0, 4.2.2 Oct 10, 2020
@HJianBo
Copy link
Member

HJianBo commented Oct 10, 2020

And I think it is useful for emqx-ce-v4.2.2. Can you open a new PR to dev/v4.2.2 after this PR approved?

@HJianBo HJianBo removed this from the 4.2.2 milestone Oct 10, 2020
@HJianBo HJianBo merged commit 97d21bd into emqx:dev/e4.2.0 Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HJianBo HJianBo HJianBo requested changes

Assignees

@HJianBo HJianBo

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can the disconnection time include the disconnection time?
2 participants
@wwhai @HJianBo