-
-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProxyHeadersMiddleware
not using the X-Forwarded-Port
header
#1974
Comments
The discussion is already created. |
victor-torres
added a commit
to victor-torres/uvicorn
that referenced
this issue
Sep 30, 2024
… to populate remote address info (closes encode#1974)
3 tasks
Is there any server implementation that uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discussed in #1948
Originally posted by fiannac April 21, 2023
From the documentation:
--proxy-headers / --no-proxy-headers Enable/Disable X-Forwarded-Proto, X-Forwarded-For, X-Forwarded-Port to populate remote address info.
But I've noticed that, when the flag is set, the
X-Forwarded-Port
is not actually used by the application, and the source port is always set to 0.This has to do with how the `ProxyHeadersMiddleware' is implemented, which does not match the behavior described in the docs.
Important
The text was updated successfully, but these errors were encountered: