From 3a4725522e13a0302823eba2b775457be55b9aba Mon Sep 17 00:00:00 2001 From: Ruben Hensen Date: Thu, 30 Jul 2026 19:03:06 +0200 Subject: [PATCH] ci: qualify both nginx config check names with their app MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit apps/outlook-addon and apps/website each had a job named `nginx config test`. A required status check is matched by name across the whole repository, so the two were indistinguishable to branch protection: requiring the name would cover both copies, and deleting either job would leave the name still reporting from the other — a gate that looks alive while covering half of what it names. Both were therefore left out of the required set added in #155. Only the display name changes. Both job ids stay `nginx`, so outlook-addon.yml's `needs: [check, test, urls, nginx]` still resolves. --- .github/workflows/outlook-addon.yml | 8 +++++++- .github/workflows/website.yml | 6 +++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/.github/workflows/outlook-addon.yml b/.github/workflows/outlook-addon.yml index 766ce710..b9a8624f 100644 --- a/.github/workflows/outlook-addon.yml +++ b/.github/workflows/outlook-addon.yml @@ -231,7 +231,13 @@ jobs: exit "$fail" nginx: - name: nginx config test + # Qualified with the app, and it has to stay that way: website.yml has a + # job that validates ITS nginx config, and a required status check is + # matched by name across the whole repo. While both were called + # `nginx config test`, requiring that name covered both copies — and + # deleting either job would have left the name still reporting from the + # other, so the gate would look alive while covering half of it. + name: nginx config test (outlook-addon) runs-on: ubuntu-latest steps: - uses: actions/checkout@v6 diff --git a/.github/workflows/website.yml b/.github/workflows/website.yml index 030ebfca..e1bd9ca6 100644 --- a/.github/workflows/website.yml +++ b/.github/workflows/website.yml @@ -107,7 +107,11 @@ jobs: - run: pnpm lint:css nginx: - name: nginx config test + # Qualified with the app — see the matching note in outlook-addon.yml. + # Both jobs were called `nginx config test`, and a required status check + # is matched by name across the whole repo, so the two were + # indistinguishable to branch protection. + name: nginx config test (website) runs-on: ubuntu-latest steps: - uses: actions/checkout@v6