Email addresses are capitalised but always stored in Yivi in lower case

[DibranMulder]

The recipient should reveal their email address according to how the sender has configured it, but the Yivi app always stores them lower case while in PostGuard people can use caps.

[DibranMulder]

/dobby can you look at this issue.

[dobby-coder]

Cross-linking with encryption4all/postguard-website#82 — filed one day later with a more detailed write-up of the same root cause and a proposed fix at the attribute/comparison-rule layer (so every client doesn't have to remember to .toLowerCase()). Keeping both open for per-platform tracking.

— Dobby (scheduled backlog maintenance)

[dobby-coder]

Traced the relevant code paths for this issue:

• src/lib/utils.ts:6 — toEmail() helper always returns lowercased email
• src/background/background.ts:415,428,568 — all recipient/sender addresses pass through toEmail() before being used as keys or serialized
• src/background/background.ts:421 — email attribute values are explicitly lowercased (v.toLowerCase()) when serializing recipient policies for the crypto popup
• src/pages/policy-editor/policy-editor.ts:76,88,90 — the email attribute input is readOnly and pre-filled with the lowercased recipient key; the user cannot type caps there
• src/pages/yivi-popup/yivi-popup.ts:99 — the email attribute is filtered out of extraAttribute() calls (it's already set by pg.recipient.email(...) with the lowercased address)

The original fix from commit c0cf421 ("fix: email values always lower case", Dec 2022) plus subsequent hardening (the readOnly lock in the policy editor, the sender-attribute filter, the yivi-popup guard) seems to close the per-client side of this issue for tb-addon. The cross-linked postguard-website#82 still proposes moving the normalization into the attribute/comparison-rule layer so clients don't have to remember to .toLowerCase(), which remains the more resilient long-term fix.

Recommend closing this tb-addon-specific ticket in favor of the centralized fix tracked in postguard-website#82 — unless someone can reproduce a current case where the tb-addon still sends caps to Yivi.

— Dobby (scheduled backlog maintenance)

[dobby-coder]

/dobby please pick this up — P1 bug: email addresses capitalised but stored lowercase in Yivi. Triggered as fan-out from encryption4all/dobby#78.

[dobby-coder]

Dobby has the request! This agent will look into the capitalisation-versus-lowercase situation in the tb-addon — Dobby will check whether the previous trace is still accurate, reproduce if possible, and ship a real fix or a closing rationale. Dobby promises not to make a meal of it.

[dobby-coder]

Re-verified — no code change needed in tb-addon

Picking this up from the prioritisation fan-out. Re-traced the email paths against main and the earlier analysis still holds:

• src/lib/utils.ts:6 — toEmail() always lowercases.
• src/background/encryption-flow.ts:59 — serializeRecipients runs every address through toEmail().
• src/background/encryption-flow.ts:65 — when a custom policy carries the email attribute, v is explicitly .toLowerCase()-ed before going to pg-js / Yivi.
• src/pages/policy-editor/policy-editor.ts:88,90 — the email attribute input is readOnly and locked to the lowercased recipient key; users can't type caps there.
• src/pages/yivi-popup/yivi-popup.ts:99 — email is filtered out of extraAttribute() (already set via pg.recipient.email(...)).

Regression coverage is already in the suite:

• tests/utils.test.ts:14,32 — pins lowercasing for Name <ADDR> and bare uppercase input.
• tests/encryption-flow.test.ts:120 — pins lowercasing of the pbdf.sidn-pbdf.email.email attribute value inside a custom policy.

The remaining concern — Yivi storing addresses lowercase while PostGuard accepts caps — is a cross-system normalization issue, and the right place for that fix is at the attribute / comparison-rule layer, which is tracked at encryption4all/postguard-website#82.

Recommendation: close this tb-addon-specific ticket and continue tracking the centralised fix at postguard-website#82. Happy to reopen if anyone can repro the tb-addon still sending caps to Yivi on current main.