From a16a1ed675cfd4810ca4580777443eca3476d4b1 Mon Sep 17 00:00:00 2001 From: Tet-9 Date: Sat, 30 May 2026 02:55:14 +0100 Subject: [PATCH] fix(miners): normalize join conditions in getPullRequestsByRepo to LOWER() for case-insensitive repo matching LEFT JOINs to pr_review_summary and repos used exact-case p.repo_full_name while the windows CTE join used LOWER(p.repo_full_name). Mixed-case repos would cause both LEFT JOINs to return NULL, silently dropping review summary and repo metadata from scoring output. Fixes #152 --- packages/das/src/api/miners/miners.service.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/das/src/api/miners/miners.service.ts b/packages/das/src/api/miners/miners.service.ts index 2469d98..7feae87 100644 --- a/packages/das/src/api/miners/miners.service.ts +++ b/packages/das/src/api/miners/miners.service.ts @@ -185,10 +185,10 @@ export class MinersService { SELECT${PR_SELECT_COLUMNS} FROM pull_requests p LEFT JOIN pr_review_summary rs - ON rs.repo_full_name = p.repo_full_name + ON LOWER(rs.repo_full_name) = LOWER(p.repo_full_name) AND rs.pr_number = p.pr_number LEFT JOIN repos r - ON r.repo_full_name = p.repo_full_name + ON LOWER(r.repo_full_name) = LOWER(p.repo_full_name) WHERE p.author_github_id = $1 AND ( (p.state = 'OPEN' AND p.created_at >= $2) @@ -234,10 +234,10 @@ export class MinersService { JOIN windows w ON w.repo_full_name = LOWER(p.repo_full_name) LEFT JOIN pr_review_summary rs - ON rs.repo_full_name = p.repo_full_name + ON LOWER(rs.repo_full_name) = LOWER(p.repo_full_name) AND rs.pr_number = p.pr_number LEFT JOIN repos r - ON r.repo_full_name = p.repo_full_name + ON LOWER(r.repo_full_name) = LOWER(p.repo_full_name) WHERE p.author_github_id = $1 AND ( (p.state = 'OPEN' AND p.created_at >= w.since)