-
Notifications
You must be signed in to change notification settings - Fork 117
feat: initial implementation of openai responses api #1429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sivanantha321
wants to merge
5
commits into
envoyproxy:main
Choose a base branch
from
sivanantha321:response-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
- Implement unit tests for the OpenAI responses translator in `openai_responses_test.go`, covering request body handling, response body processing, streaming response handling, and error conversion. - Introduce metrics tests in `responses_metrics_test.go` to validate token usage and latency recording. - Enhance tracing tests in `api_test.go`, `request_attrs_test.go`, `response_attrs_test.go`, and `responses_test.go` to ensure proper attribute recording for requests and responses. - Add tests for the responses span in `span_test.go` to verify correct behavior during response recording and error handling. - Validate the responses tracer exporter behavior in `tracing_test.go` to ensure correct integration with OpenTelemetry. Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
…ckage Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
… body Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
ee26893 to
a588b67
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1429 +/- ##
==========================================
+ Coverage 83.67% 83.79% +0.11%
==========================================
Files 139 143 +4
Lines 12302 12822 +520
==========================================
+ Hits 10294 10744 +450
- Misses 1400 1445 +45
- Partials 608 633 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… methods in responsesProcessorUpstreamFilter Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
a70d9da to
f783d51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues/PRs (if applicable)
Special notes for reviewers (if applicable)