Skip to content

Conversation

@sivanantha321
Copy link
Contributor

Description

Related Issues/PRs (if applicable)

Special notes for reviewers (if applicable)

@yuzisun yuzisun changed the title Intial implementation of openai resposes api Intial implementation of openai responses api Oct 24, 2025
@yuzisun yuzisun changed the title Intial implementation of openai responses api feat: Intial implementation of openai responses api Oct 27, 2025
@yuzisun yuzisun changed the title feat: Intial implementation of openai responses api feat: Initial implementation of openai responses api Oct 27, 2025
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
- Implement unit tests for the OpenAI responses translator in `openai_responses_test.go`, covering request body handling, response body processing, streaming response handling, and error conversion.
- Introduce metrics tests in `responses_metrics_test.go` to validate token usage and latency recording.
- Enhance tracing tests in `api_test.go`, `request_attrs_test.go`, `response_attrs_test.go`, and `responses_test.go` to ensure proper attribute recording for requests and responses.
- Add tests for the responses span in `span_test.go` to verify correct behavior during response recording and error handling.
- Validate the responses tracer exporter behavior in `tracing_test.go` to ensure correct integration with OpenTelemetry.

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 86.53846% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.79%. Comparing base (df87d58) to head (f783d51).

Files with missing lines Patch % Lines
internal/extproc/responses_processor.go 85.23% 23 Missing and 12 partials ⚠️
internal/extproc/translator/openai_responses.go 83.62% 11 Missing and 8 partials ⚠️
internal/tracing/tracer.go 58.33% 8 Missing and 2 partials ⚠️
internal/apischema/openai/openai.go 71.42% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1429      +/-   ##
==========================================
+ Coverage   83.67%   83.79%   +0.11%     
==========================================
  Files         139      143       +4     
  Lines       12302    12822     +520     
==========================================
+ Hits        10294    10744     +450     
- Misses       1400     1445      +45     
- Partials      608      633      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sivanantha321 sivanantha321 changed the title feat: Initial implementation of openai responses api feat: initial implementation of openai responses api Oct 31, 2025
… methods in responsesProcessorUpstreamFilter

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
@sivanantha321 sivanantha321 marked this pull request as ready for review October 31, 2025 11:21
@sivanantha321 sivanantha321 requested a review from a team as a code owner October 31, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants