Skip to content

Commit

Permalink
Fix typo - adjustNewConnectionIdForRouting (#27456)
Browse files Browse the repository at this point in the history
Signed-off-by: Raven Black <[email protected]>
  • Loading branch information
ravenblackx authored May 18, 2023
1 parent 29334c2 commit 58335ef
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion source/common/quic/envoy_quic_utils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ void configQuicInitialFlowControlWindow(const envoy::config::core::v3::QuicProto
static_cast<quic::QuicByteCount>(session_flow_control_window_to_send)));
}

void adjustNewConnectionIdForRoutine(quic::QuicConnectionId& new_connection_id,
void adjustNewConnectionIdForRouting(quic::QuicConnectionId& new_connection_id,
const quic::QuicConnectionId& old_connection_id) {
char* new_connection_id_data = new_connection_id.mutable_data();
const char* old_connection_id_ptr = old_connection_id.data();
Expand Down
2 changes: 1 addition & 1 deletion source/common/quic/envoy_quic_utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ void configQuicInitialFlowControlWindow(const envoy::config::core::v3::QuicProto

// Modify new_connection_id according to given old_connection_id to make sure packets with the new
// one can be routed to the same listener.
void adjustNewConnectionIdForRoutine(quic::QuicConnectionId& new_connection_id,
void adjustNewConnectionIdForRouting(quic::QuicConnectionId& new_connection_id,
const quic::QuicConnectionId& old_connection_id);

} // namespace Quic
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ EnvoyDeterministicConnectionIdGenerator::GenerateNextConnectionId(
const quic::QuicConnectionId& original) {
auto new_cid = DeterministicConnectionIdGenerator::GenerateNextConnectionId(original);
if (new_cid.has_value()) {
adjustNewConnectionIdForRoutine(new_cid.value(), original);
adjustNewConnectionIdForRouting(new_cid.value(), original);
}
return (new_cid.has_value() && new_cid.value() == original) ? absl::nullopt : new_cid;
}
Expand All @@ -23,7 +23,7 @@ EnvoyDeterministicConnectionIdGenerator::MaybeReplaceConnectionId(
const quic::QuicConnectionId& original, const quic::ParsedQuicVersion& version) {
auto new_cid = DeterministicConnectionIdGenerator::MaybeReplaceConnectionId(original, version);
if (new_cid.has_value()) {
adjustNewConnectionIdForRoutine(new_cid.value(), original);
adjustNewConnectionIdForRouting(new_cid.value(), original);
}
return (new_cid.has_value() && new_cid.value() == original) ? absl::nullopt : new_cid;
}
Expand Down

0 comments on commit 58335ef

Please sign in to comment.