-
Notifications
You must be signed in to change notification settings - Fork 2
Issue 46: refactor model definition #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 305 325 +20
=========================================
+ Hits 305 325 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I had a go at shortening the overview as I felt like it was a bit wordy. This might be a bit drastic. The baselinenowcast model, initially developed as a reference for the COVID-19 hospital admissions nowcasting challenge in Germany (2021-2022), utilises reporting triangles of preliminary case counts and their delays. It applies a multiplicative approach, using empirically observed historical delay distributions to estimate yet-to-be-observed cases. |
This looks good to me but the language here depends on our answers to #74 (because here you are using point nowcast to mean fill in the reporting triangle, which is also how I have used it, but in other places it means the estimate of the sum across delays for each reference time). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the nomenclature discussion this looks good.
I think I would prefer to merge this now and then open a new PR to update all the docs and function names after we decide on the naming convention |
sounds good |
Description
This PR closes #46.
It restructures the methods to be more consistent with the code (linking to the explicitly linking to the functions that pertain to the model components).
Checklist