Skip to content

test: DFD visual-regression baselines stale since #676; dynamic TM names destabilize screenshots #830

Description

@ericfitz

Summary

All DFD VRT plates currently fail for two pre-existing, additive reasons — neither related to app rendering:

  1. Stale baselines: PR chore: review all en-US localized strings for proper capitalization #676 (May 9, commit 5e08187) lowercased default node-shape labels ("Data Store" → "Data store", "Security Boundary" → "security boundary") but the VRT baselines were never regenerated. Plate 1's diff shows exactly this text-casing delta.
  2. Unstable capture geometry: per-test threat-model names include a timestamp+suffix, so the header block's height varies run to run, cascading a vertical offset through every full-page screenshot (visible on plates with no text diff at all, e.g. plate 3).

Acceptance Criteria

  • Stabilize capture: fixed-width/fixed-content header during VRT capture (static TM name for VRT fixtures, or mask/clip the header region in toHaveScreenshot).
  • Regenerate all DFD VRT baselines after stabilization.
  • Verify two consecutive clean runs produce zero pixel diff.

Notes

Metadata

Metadata

Assignees

No one assigned

    Labels

    size:MThis PR changes 30-99 lines, ignoring generated files.

    Projects

    Status
    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions