Skip to content

Updates to Lectures #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giles-twiss wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updates to Lectures #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8db2c96
Commit to trigger workflows.
giles-twiss Oct 27, 2021
93b691e
Add factorial function.
giles-twiss Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# CI MPM
Toy repo for CI lecture.
Toy repo for CI lecture and some simple changes
10 changes: 9 additions & 1 deletion simple_functions/functions1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@

__all__ = ['my_sum']
from functools import lru_cache

__all__ = ['my_sum','factorial']


def my_sum(iterable):
tot = 0
for i in iterable:
tot += i
return tot

@lru_cache # Note: -> @cache in python >= 3.9
def factorial(n):
return n * factorial(n-1) if n else 1


16 changes: 13 additions & 3 deletions tests/test_simple_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import pytest

from simple_functions import my_sum

import sys
sys.path.append("../")
from simple_functions import my_sum, factorial

class TestSimpleFunctions(object):
'''Class to test our simple functions are working correctly'''
Expand All @@ -14,3 +14,13 @@ def test_my_add(self, iterable, expected):
'''Test our add function'''
isum = my_sum(iterable)
assert isum == expected

@pytest.mark.parametrize('number, expected', [
(5, 120),
(3, 6),
(1, 1)
])
def test_factorial(self, number, expected):
'''Test our factorial function'''
answer = factorial(number)
assert answer == expected