Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Window Border Doesn't Work #68

Open
davidv3rs opened this issue Mar 28, 2020 · 15 comments
Open

Active Window Border Doesn't Work #68

davidv3rs opened this issue Mar 28, 2020 · 15 comments

Comments

@davidv3rs
Copy link

Not sure if this is necessarily a Krohnkite issue, but the window border script doesn't seem to be working for me. This is from my kdeglobals file. It doesn't seem to have any effect after rebooting or relogging. Is there another step that I'm missing?

[WM]
activeBackground=47,52,63
activeBlend=47,52,63
activeForeground=211,218,227
frame=61,174,233
inactiveBackground=47,52,63
inactiveBlend=47,52,63
inactiveForeground=102,106,115
inactiveFrame=239,240,241

@cyruseuros
Copy link

Application Style > Window Decorations > Uncheck "Use theme's default window borders" and click "Apply"

@ephur
Copy link

ephur commented Apr 4, 2020

I have unchecked that, and have the same result (lack of window borders)

@cyruseuros
Copy link

Long shot, but are you perhaps setting your custom borders to no borders?

Also, for that setting to properly apply I had to restart my plasma session at times.

@SamDM
Copy link

SamDM commented Apr 4, 2020

I think it might be related to the 'maximization' status of a window. I looks like tiled windows can be 'maximized' even though they are still tiled with other windows. And kde does not draw borders on maximized windows.

Notice the blue border at the bottom of the window appear and disappear by 'maximizing'.
(I use the 'no side borders' setting in window decorations)

Peek 2020-04-04 12-55

@cyruseuros
Copy link

Oh, ok, I forgot where the setting is, but you have to enable "allow resizing of maximized windows". That will also draw the borders.

@SamDM
Copy link

SamDM commented Apr 4, 2020

Found it :)

help_window

At least for me this solves the problem. Thanks!

@cyruseuros
Copy link

@esjeon should this be in the README?

@esjeon
Copy link
Owner

esjeon commented Apr 5, 2020

Thanks @jjzmajic for figuring things out. Many things have changed since I first wrote the README.

should this be in the README?

Yes, I think the documentation should include this info.

Also, I'm working on the support for the Kwin-native maximization, which will also affect some settings.

@ephur
Copy link

ephur commented Apr 5, 2020

I tried the above steps to get window borders and had no luck, so I continued to search. I realized there is an option in the Krohnkite -> Options -> Remove Borders of Tiled Windows. I have that selected, because it's the only way I found to get rid of the other window decorations (window buttons etc.,). This obviously removes the window borders as well. Is there a way to separate these options?

@cyruseuros
Copy link

@ephur as far as I know, only the regex-based override mentioned in the README. Use that to hide window decorations. Then you don't have to hide the borders as well.

@esjeon The kwin native maximization features sounds awesome. Wish I could help, but I never picked up typescript. Any other way I can help? Maybe updating the README? I'm guessing there are more things that have changed since

@esjeon
Copy link
Owner

esjeon commented Apr 6, 2020

Maybe updating the README

@jjzmajic Updating README will be helpful too, because recently I have not enough time to look into details outside of the code itself.

@sebastiangelotte
Copy link

sebastiangelotte commented May 6, 2020

I tried the above steps to get window borders and had no luck, so I continued to search. I realized there is an option in the Krohnkite -> Options -> Remove Borders of Tiled Windows. I have that selected, because it's the only way I found to get rid of the other window decorations (window buttons etc.,). This obviously removes the window borders as well. Is there a way to separate these options?

I still can't manage to get the borders to show. Any idea of what I might be doing wrong? Here are my settings:

Edit: Ok, I found what the problem was. It's just me being stupid and not understanding the UI. In Settings -> Application Style -> Window Decorations I had "No borders" chosen in the dropdown. Somehow I figured that if the checkbox wasn't active, the dropdown wouldn't matter, but it does of course.

For anyone looking for the Krohnkite -> Options -> Remove Borders of Tiled Windows you first have to enable user configuration. It's explained in the readme here https://github.com/esjeon/krohnkite#enabling-user-configuration

Also, this tip helped me to get borders working on Firefox: https://www.reddit.com/r/kde/comments/9oqy5d/hot_to_get_decorations_for_firefoxs_window_when/

New correct settings:
image

image

image

kdeglobals:
image

@hiringManager
Copy link

Just leaving a comment to say that I ran into this exact same issue on a new 20.04 install yesterday, although floating util windows had borders. My solution was actually to detick the 'keep floating windows above tiled windows'. I'm not why this was the case, but my borders are functioning as intended now.

image

@smsegal
Copy link

smsegal commented Oct 15, 2020

If I wanted to enable this in another KDE theme, say Arc Dark, what would I have to adjust in the ~/.config/kdeglobals file?

@fabianski7
Copy link

Color themes that have the [Colors:Header] tags don't seem to be compatible with this and the border color is not changed even after writing the data to the ~/.config/kdeglobals file

Most color schemes on store.kde.org do not have this tag, so they do not have this problem. There is also a theme with the same colors as breeze without the header that was added in version 5.21.
https://store.kde.org/p/1490911/
https://store.kde.org/p/1490912/

There is already an open bug reporting this, if any fellow here wants to help by confirming the bug there it will be helpful for us to see a solution to this.
https://bugs.kde.org/show_bug.cgi?id=433761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants