Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of warnings that you can ignore through .gradient_ignore.exs #161

Open
hworld opened this issue Mar 14, 2023 · 2 comments
Open

List of warnings that you can ignore through .gradient_ignore.exs #161

hworld opened this issue Mar 14, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@hworld
Copy link

hworld commented Mar 14, 2023

I'm having some trouble figuring out what the list of warnings I can ignore are.

For example, when seeing a warning like this (which I believe was already reported elsewhere):

apps/grid/lib/grid_web/views/error_view.ex:2: The spec template_not_found/2 doesn't match the function name/arity

I'm not sure by looking at this error how I would be able to ignore it, besides just putting the file:location in the gradient_ignore file. It would be nice to ignore just the one specific issue that came up. Is there a way to figure these warning specifiers?

@erszcz erszcz added the enhancement New feature or request label Mar 28, 2023
@Nezteb
Copy link

Nezteb commented Apr 13, 2023

Something similar to dialyxir's --format ignore_file flag would be nice: https://github.com/jeremyjh/dialyxir#command-line-options

This would also make it easier to add gradient to an existing Elixir project: ignore all the existing errors and only fail if new ones are added.

Similarly, a --list-unused-filters flag (or something like it) would be useful for un-ignoring errors once they've been fixed so that they don't crop up again: https://github.com/jeremyjh/dialyxir#list-unused-filters (though this should probably be a separate issue?)

@erszcz
Copy link
Member

erszcz commented Apr 14, 2023

Good ideas, thanks! We'll come up with something to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants