Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: TS type error in index.d.ts #316

Closed
1 task
ox-cc-fspd opened this issue Jul 26, 2024 · 3 comments · Fixed by #317
Closed
1 task

Bug: TS type error in index.d.ts #316

ox-cc-fspd opened this issue Jul 26, 2024 · 3 comments · Fixed by #317

Comments

@ox-cc-fspd
Copy link

ox-cc-fspd commented Jul 26, 2024

Environment

Node version: 20.9.0
npm version:
ESLint version: 9.x
eslint-plugin-n version: 17.10.0
Operating System: Win11

What rule do you want to report?

all rules

Link to Minimal Reproducible Example

What did you expect to happen?

I am using a TypeScript wrapper around this plugin.

Using v17.10.0 gives TS type errors, because the index.d.ts does not contain a declaration for type Configs anymore, as there was in v17.9.0. There is only a JSDoc type declaration which does not help in a real TS env.

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response

@ox-cc-fspd ox-cc-fspd added the bug label Jul 26, 2024
@scagood
Copy link

scagood commented Jul 26, 2024

Can you link to a repo or make a quick playground example of this being an issue please?


Edit:

Oh, OH! I see its our exported tsconfig.json not your eslint config 😱

@scagood
Copy link

scagood commented Jul 26, 2024

This looks to be a ts 5.5 issue, as things start to work again in ts 5.4.

This screams that we need Type coverage 🤔

@danielrentz
Copy link

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants