feat: Option to track JSX components as references #646
+369
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
672
to
675
| JSXOpeningElement(node) { | ||
| const name = node.name.name; | ||
|
|
||
| if (this.scopeManager.__isJSXEnabled() && name[0].toUpperCase() === name[0]) { |
There was a problem hiding this comment.
This would crash if node.name is not a JSXIdentifier. For example: <obj.prop/>.
There was a problem hiding this comment.
Ah, didn't even know that syntax was possible. I'll update it.
|
Updated and also added a few tests to ensure that JSX references are being tracked the same way regular references are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
What changes did you make? (Give an overview)
jsxoption toanalyze().Referencerto track JSX references.Related Issues
fixes #645
Is there anything you'd like reviewers to focus on?
Please double-check that I'm covering enough scenarios in the tests. I'm not very familiar with JSX, so it's possible I missed some cases.